A missing return "derandom" in monika_conventions#10198
Open
Wingdinggaster656 wants to merge 2 commits intoMonika-After-Story:content-12from
Open
A missing return "derandom" in monika_conventions#10198Wingdinggaster656 wants to merge 2 commits intoMonika-After-Story:content-12from
return "derandom" in monika_conventions#10198Wingdinggaster656 wants to merge 2 commits intoMonika-After-Story:content-12from
Conversation
Contributor
There was a problem hiding this comment.
MonikaModDev/Monika After Story/game/updates.rpy
Lines 378 to 382 in ccafefa
Better leave that to maintainers. We have no idea if the next release would be 0_12_x or 0_13_x ahead of time. This line will have no effect as the proposed changes did not appear in 0.12.15.
Booplicate
added
the
priority: low
Member
|
This is smol. I rebased to content12, but it needs to be updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Conventionstopic is a topic that asks players questions and then sets PM variables.Since other topics related to PM variables seem to have
return "derandom", I think this should also be included.