Skip to content

Conversation

@Migggz
Copy link

@Migggz Migggz commented Dec 17, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

⚠️ No Changeset found

Latest commit: efd414c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 17, 2025

@Migggz is attempting to deploy a commit to the momensherif's projects Team on Vercel.

A member of the Team first needs to authorize it.

…cements

- Removed GithubLoginButton
- Simplified Building Github OAuth URL using URLSearchParams
-
Simplified OAuthError Builder and its states
- Refactor PopupWindow and Simplified the code
-
Updated README accordingly

BREAKING CHANGE: Removed the GithubLoginButton
@Migggz
Copy link
Author

Migggz commented Dec 18, 2025

@MomenSherif The only thing left is updating the root README.md to reflect that we now have two packages: one for Google and one for GitHub.

We can add a few simple usage snippets for each, along with links to their individual READMEs so users can check the full documentation.

I’ll leave this part to you if you want, or I can handle it myself, whatever works for you 😄

@MomenSherif
Copy link
Owner

I would love if you can do it 🙌🏻،

Have separate README for each package guide inside the package.

And the root README, shows the two packages and links for each doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants