fix: reject aliased cell-list layouts#274
Open
galjos wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #274 +/- ##
=======================================
Coverage 88.12% 88.13%
=======================================
Files 283 283
Lines 10874 10879 +5
Branches 3376 3379 +3
=======================================
+ Hits 9583 9588 +5
Misses 1251 1251
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
⚡ Performance (instruction count) — ✅ no regressionsper-benchmark breakdown
Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock. |
ape33
requested changes
Jun 22, 2026
| for (size_t i = 0; i < 3; ++i) | ||
| if (_nCells[i] < requiredCells[i]) | ||
| throw CellListException( | ||
| "Number of cells per dimension must be at least " |
Member
There was a problem hiding this comment.
please make the error message more expressive:
add the corresponding dimension (i=0 -> x, i=1 -> y, i=2 -> z) which throws the error
and also add the possible solutions to the error in the error message, i.e. decreasing the coulomb radius cutoff and/or increasing the number of cells in the cell list approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The half-neighbor cell-list stencil assumes enough cells per dimension to represent each neighbor offset without wrapping onto already represented cells. If
nCells < 2 * nNeighbourCells + 1, periodic wrapping can alias offsets and make the neighbor list mathematically invalid.Validation
cmake --build build-stochastic-rescale-ci --target testCelllist testCelllistSetup --parallel 4ctest --test-dir build-stochastic-rescale-ci -R '^(testCelllist|testCelllistSetup)$' --output-on-failureReference