[210_13] srfi-19 time-difference实现 #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetjinser
requested changes
Feb 11, 2026
goldfish/srfi/srfi-19.scm
Outdated
| (unless (eq? (time-type time1) (time-type time2)) | ||
| (error 'wrong-type-arg "time-difference: time types must match" | ||
| (list (time-type time1) (time-type time2)))) | ||
| (set-time-type! time3 TIME-DURATION) |
Collaborator
There was a problem hiding this comment.
这里不需要再 set-time-type! 了，传进来的就是
goldfish/srfi/srfi-19.scm
Outdated
Comment on lines
174
to
183
| (if (and (= (time-second time1) (time-second time2)) | ||
| (= (time-nanosecond time1) (time-nanosecond time2))) | ||
| (begin | ||
| (set-time-second! time3 0) | ||
| (set-time-nanosecond! time3 0)) | ||
| (receive (nanos secs) | ||
| (priv:nanoseconds->values (- (priv:time->nanoseconds time1) | ||
| (priv:time->nanoseconds time2))) | ||
| (set-time-second! time3 secs) | ||
| (set-time-nanosecond! time3 nanos))) |
Collaborator
There was a problem hiding this comment.
- 不需要判相等设置0，直接计算就行
- 不要写
priv:nanoseconds->values这个小函数，命名不清楚，而这里直接写 floor/ 内联进来就行。
added 2 commits
February 11, 2026 09:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.