docs(user): de-dev polish — strip internal scaffolding (Phase 3a)#226
Merged
Conversation
… (Phase 3a) Remove developer-only scaffolding that leaked into the public user/operator docs, while preserving every user-facing behavior, command, flag, endpoint, constant, and env var. No behavior changes. Removed across 18 files: - internal ticket / sequencing refs (MR-NNN, RFC-NNN, "Phase N"); - source-code paths (crates/**/*.rs, *.pest) and internal struct/function dumps (e.g. the QueryIR / GraphCommit / SchemaMigrationPlan Rust types, internal fn names like fork_branch_from_state, optimize_all_tables); - Lance-internal blocker prose (upstream issue numbers, blob-decode cause, sidecar Phase-B/C mechanics) — keeping the user-visible behavior (e.g. "optimize skips Blob-column tables; reads/writes unaffected"); - pre-v0.4.0 Run-state-machine archaeology. Internal IR/lowering/recovery-internals sections were either trimmed to a brief user-facing note (e.g. "Traversal execution", "interrupted writes recover automatically; recovery commits are recorded under actor omnigraph:recovery") or removed. Kept: all language syntax, lint codes, Cedar actions/scopes, endpoints, error taxonomy, every constant and env var (verified none dropped from the constants cheat-sheet), and the operator-facing explanations of on-disk artifacts. Residual "legacy" mentions are all user-facing (the deprecated omnigraph.yaml, the legacy token chain, old command names). Verified: zero internal-scaffolding leaks (MR/RFC/Phase/.rs/.pest = 0) across docs/user; zero broken links; check-agents-md.sh green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3a of the docs restructure (Phase 1 #223, Phase 2 #225 — both merged).
Docs only, no behavior changes.
Removes developer-only scaffolding that leaked into the public user/operator docs
while preserving every user-facing behavior, command, flag, endpoint, constant,
and env var.
Removed across 18 files
MR-NNN,RFC-NNN, "Phase N").crates/**/*.rs,*.pest) and internal struct/function dumps(the
QueryIR/GraphCommit/SchemaMigrationPlanRust types, internal fnnames).
sidecar Phase-B/C mechanics) — keeping the user-visible behavior.
Internal IR / lowering / recovery-internals sections were trimmed to brief
user-facing notes or removed.
Kept
All language syntax, lint codes, Cedar actions/scopes, endpoints, error taxonomy,
every constant and env var (verified none dropped from the cheat-sheet), and
operator-facing explanations of on-disk artifacts. Residual "legacy" mentions are
all user-facing (deprecated
omnigraph.yaml, the legacy token chain, old commandnames).
Verification
MR/RFC/Phase/.rs/.pest= 0) acrossdocs/user..mdlinks.scripts/check-agents-md.shgreen.Still to come
guides/). The original plan was to minethe old
omnigraph-website, but it's deprecated and the new site is a flat repomirror — so guides would be net-new content; scoping separately.
🤖 Generated with Claude Code
Greptile Summary
Phase 3a doc cleanup across 18
docs/user/files: removes internal Rust source paths, ticket/RFC references, pre-v0.4.0 Run-state-machine archaeology, and internal struct/function dumps while preserving every user-facing behavior, CLI flag, endpoint, env var, and constant.Phasebut notStage, leaving twoStage 3Aand oneStage 2Clabels (internal development milestone shorthand) indocs/user/clusters/config.mdanddocs/user/cli/reference.md— the same class of planning shorthand the PR explicitly targets per AGENTS.md Rule 5.Confidence Score: 4/5
Docs-only change with no runtime impact; safe to merge as-is, with one small follow-up worth doing before the final polish is considered complete.
The cleanup is thorough across 16 of 18 files. The two cluster-related files still carry Stage 3A and Stage 2C labels that are the same kind of internal milestone shorthand the PR explicitly set out to remove. The verification script checked for Phase but not Stage, so they slipped through. Everything else was verified present in the final state.
docs/user/clusters/config.md (lines 60 and 455) and docs/user/cli/reference.md (line 191) still contain Stage 3A and Stage 2C internal labels.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[18 docs/user files] --> B{Content type} B --> C[Internal scaffolding REMOVED] B --> D[User-facing content KEPT] C --> C1[MR-NNN / RFC-NNN ticket refs] C --> C2[Rust source paths] C --> C3[Internal fn names] C --> C4[Rust struct dumps] C --> C5[Phase B/C sidecar mechanics] C --> C6[Pre-v0.4.0 Run state machine] D --> D1[All CLI commands and flags] D --> D2[All HTTP endpoints and auth model] D --> D3[All Cedar actions and scopes] D --> D4[All env vars and tunables] D --> D5[Error taxonomy and lint codes] D --> D6[Schema and query syntax] C --> E{Verification} E --> F[Phase grep passed] E --> G[MR/RFC/rs/pest grep passed] E --> H[Stage N grep missed] H --> I[Stage 3A in clusters/config.md line 60 and Stage 2C line 455 and Stage 3A in cli/reference.md line 191]Comments Outside Diff (1)
docs/user/clusters/config.md, line 60 (link)Stage 3Ahere (andStage 2Con line 455) are the same class of internal planning shorthand as thePhase Nreferences this PR explicitly targets. The verification check in the PR description only grep'd forPhase, soStagesurvived. An outside contributor or operator reading this has no way to resolve what "Stage 3A" means — it's not a version, a PR, or a public milestone.Same pattern in
docs/user/cli/reference.mdline 191:Stage 3A accepts graphs, schemas, stored queries, and policy bundle file references.Both should be rewritten to describe capability scope without the internal stage label (e.g., "OmniGraph currently supports…" or "In this release, the cluster control plane supports…").Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (1): Last reviewed commit: "docs(user): de-dev polish — strip intern..." | Re-trigger Greptile
Context used: