[Bugfix] Adapt UCM connector to vLLM kv_cache_config#955
Open
dante159753 wants to merge 2 commits into
Open
Conversation
dante159753
force-pushed
the
ucm-kv-cache-config-adapt
branch
2 times, most recently
from
e322d6d to
87986b7
Compare
dante159753
force-pushed
the
ucm-kv-cache-config-adapt
branch
from
87986b7 to
ef25409
Compare
dante159753
requested review from
FangRun2,
Infinite666,
Tarrei,
harrisonyhq,
mag1c-h,
qyh111 and
ygwpz
as code owners
ygwpz
reviewed
May 12, 2026
| def __init__(self, vllm_config, role): | ||
| def __init__( | ||
| self, | ||
| vllm_config, |
Contributor
There was a problem hiding this comment.
Missing type annotations for vllm_config and role parameters. All other connector classes use vllm_config: "VllmConfig", role: KVConnectorRole for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
now latest VLLM requires kv_cache_config in constructor, adapt UCM connector to it, without breaking the execution of older VLLM version.
Modifications
add method
_init_kv_connector_base, check if it receives kv_cache_config param, then call corresponding init methodTest