[fix] fix ucm patch causes unexpected log directory created#913
Open
Lijiachen1018 wants to merge 3 commits into
Open
[fix] fix ucm patch causes unexpected log directory created#913Lijiachen1018 wants to merge 3 commits into
Lijiachen1018 wants to merge 3 commits into
Conversation
Lijiachen1018
requested review from
FangRun2,
Tarrei,
mag1c-h and
ygwpz
as code owners
Lijiachen1018
force-pushed
the
dev_logger_fix
branch
from
e4fb626 to
53b4c23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix ucm patch causes unexpected
logdirectory created.Modifications
Remove import patch from
ucm/__init__.py. Theucm_patch.pthruns on every Python startup which importsucm.*module. And importingucmcurrently importspatch_loggerwhich will create thelogfolder globally.Test
No longer create unexpected
logdirectory.Also test on online and offline inference, the logger works as usual.
