Skip to content

Update Minecraft version detection to support version.properties #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noeppi-noeppi merged 1 commit into from
Dec 20, 2025
Merged

Update Minecraft version detection to support version.properties #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/main/java/org/moddingx/modgradle/util/ModGradleVersionAccess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardOpenOption;
import java.util.HashMap;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.*;
import java.util.jar.Attributes;
import java.util.jar.JarFile;
import java.util.zip.ZipEntry;
Expand Down Expand Up @@ -56,16 +53,26 @@ public String neoforgeMinecraft(Project project, String neoforge) {
Set<File> files = configuration.resolve();
if (files.size() != 1) throw new IllegalStateException(neoforgeUniversal + " resolved to more than one file.");
File file = files.iterator().next();
String specVersion;
String minecraftVersion;
try (JarFile zf = new JarFile(file)) {
Attributes neoformAttributes = zf.getManifest().getAttributes("net/neoforged/neoforge/versions/neoform/");
if (neoformAttributes == null) throw new IllegalStateException(neoforgeUniversal + " does not contain a neoform section in its manifest.");
specVersion = neoformAttributes.getValue("Specification-Version");
if (specVersion == null) throw new IllegalStateException("neoform manifest section has no specification version in " + neoforgeUniversal);
ZipEntry propsEntry = zf.getEntry("net/neoforged/neoforge/common/version.properties");
if (propsEntry != null) {
Properties props = new Properties();
try (InputStream in = zf.getInputStream(propsEntry)) {
props.load(in);
}
minecraftVersion = props.getProperty("minecraft_version");
if (minecraftVersion == null || minecraftVersion.isBlank()) throw new IllegalStateException("version.properties has no minecraft_version in " + neoforgeUniversal);
} else { // before NeoForge 21.10.34-beta
Attributes neoformAttributes = zf.getManifest().getAttributes("net/neoforged/neoforge/versions/neoform/");
if (neoformAttributes == null) throw new IllegalStateException(neoforgeUniversal + " does not contain a neoform section in its manifest.");
minecraftVersion = neoformAttributes.getValue("Specification-Version");
if (minecraftVersion == null) throw new IllegalStateException("neoform manifest section has no specification version in " + neoforgeUniversal);
}
}
this.neoforgeMinecraftVersions.put(neoforge, specVersion);
this.neoforgeMinecraftVersions.put(neoforge, minecraftVersion);
this.save();
return specVersion;
return minecraftVersion;
} catch (Exception e) {
throw new RuntimeException("Can't infer minecraft version", e);
}
Expand Down