Quantile Threshold Calculation + Filtering #252
Draft
+3,122
−916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `PairedThresholdFilter` class to filter text JSONL based on scores from paired JSONL files. - Introduced `ThresholdFilterPipelineBuilder` to facilitate the construction of filtering pipelines with support for local and Slurm execution. - Created tests for `PairedThresholdFilter` to ensure correct filtering behavior, handling of mismatches, and error conditions. - Developed `NumWordsFilter` for additional filtering based on word count, with corresponding tests. - Implemented `ScoresParser` for parsing scores JSONL files with threshold filtering capabilities, including tests for various scenarios. - Updated documentation and added example configurations for the new filtering pipeline.
- Updated configuration to support multiple input directories for text, scores, and optional domains. - Added parameters for handling paired alignment errors and word-count filtering. - Introduced a local dummy configuration for testing with paired data. - Deprecated the old domain filtering class in favor of a unified approach. - Modified the JSONL writer to include score and domain metadata in the output. - Adjusted tests to reflect changes in the pipeline structure and expected outputs.
…hold filter pipeline
… filter pipeline configuration
… execution helpers
- Moved relavant process to class functions from utils - Implemented unit tests for the quantile pipeline,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.