Skip to content

feat: filter by license id#1595

Merged
Alessandro100 merged 1 commit intomainfrom
feat/1563-license-filter
Feb 16, 2026
Merged

feat: filter by license id#1595
Alessandro100 merged 1 commit intomainfrom
feat/1563-license-filter

Conversation

@Alessandro100
Copy link
Contributor

@Alessandro100 Alessandro100 commented Feb 10, 2026

closes #1563

Summary:

Ability to search feeds by the top 5 licenses

Expected behavior:

When filtering by license, it should display the licenses in an OR method. It should also display a chip with the ability to clear it and have the license in the URL. It should also display the license in the search row

Testing tips:

Go on the feeds search page and play around with license filtering

Design Assumption

I filter / display the license exclusively by their ID as the real name is very long and cluttering. This is done with the assumption that people who will be interested in license data will be familiar with the abbreviations (ex: CC-BY-4.0).

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
Screenshot 2026-02-10 at 14 36 45 Screenshot 2026-02-10 at 14 36 54

@Alessandro100 Alessandro100 self-assigned this Feb 10, 2026
type: 'checkbox',
},
{
title: 'etalab-2.0',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on QA and this was the only filter to not show any data. Need to confirm if spelling is ok with db

@github-actions
Copy link

*Lighthouse ran on https://mobility-feeds-dev--pr-1595-wjra2mng.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 82 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1595-wjra2mng.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 63 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1595-wjra2mng.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 82 🔴 0 🟢 93 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1595-wjra2mng.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 92 🟠 87 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1595-wjra2mng.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 100 🟢 100 🟢 100 🟢 100

@github-actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1595-wjra2mng.web.app

@qcdyx qcdyx self-requested a review February 13, 2026 15:06
@qcdyx
Copy link
Contributor

qcdyx commented Feb 13, 2026

First, I put "New York" to search for NY feeds, then I selected, CC-BY-4.0, it shows me 2 NY feeds with that license. This is good.
But, when I removed CC-BY-4.0, and selected CC0-1.0, it shows me that We're sorry, we found no search results for “New York”. Should we better prompt the users with "We're sorry, we found no search results for New York feeds with CC0-1.0 license"?
image

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alessandro100
Copy link
Contributor Author

First, I put "New York" to search for NY feeds, then I selected, CC-BY-4.0, it shows me 2 NY feeds with that license. This is good. But, when I removed CC-BY-4.0, and selected CC0-1.0, it shows me that We're sorry, we found no search results for “New York”. Should we better prompt the users with "We're sorry, we found no search results for New York feeds with CC0-1.0 license"? image

In our current state we have a sub point saying "Try adjusting your filters or removing strict criteria". This covers if any filter: licence, feature, gbfs version, official tag return nothing. Having a custom message for each filter would be very complex

@Alessandro100 Alessandro100 merged commit 1b3ba6e into main Feb 16, 2026
4 checks passed
@Alessandro100 Alessandro100 deleted the feat/1563-license-filter branch February 16, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Filter by license id(name) in search page

3 participants