fix: Added a shared in-progress VersionInfo returned to concurrent callers#2086
Conversation
… once resolution starts
🚨 Code Formatting Issue 🚨This contribution does not follow the conventions set by the Google Java Style Guide. Please run the following command at the root of the project to fix formatting errors: ./gradlew spotlessApply🗂️ Affected files
Go to the Actions Dashboard to download the full Spotless output |
…tfs-validation-report
🚨 Code Formatting Issue 🚨This contribution does not follow the conventions set by the Google Java Style Guide. Please run the following command at the root of the project to fix formatting errors: ./gradlew spotlessApply🗂️ Affected files
Go to the Actions Dashboard to download the full Spotless output |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit a41af17 📊 Notices ComparisonNew Errors (0 out of 978 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 978 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 978 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 978 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 994 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
🚨 Code Formatting Issue 🚨This contribution does not follow the conventions set by the Google Java Style Guide. Please run the following command at the root of the project to fix formatting errors: ./gradlew spotlessApply🗂️ Affected files
Go to the Actions Dashboard to download the full Spotless output |
🚨 Code Formatting Issue 🚨This contribution does not follow the conventions set by the Google Java Style Guide. Please run the following command at the root of the project to fix formatting errors: ./gradlew spotlessApply🗂️ Affected files
Go to the Actions Dashboard to download the full Spotless output |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit e0da28f 📊 Notices ComparisonNew Errors (1 out of 987 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 3c2fe93 📊 Notices ComparisonNew Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 987 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check16 out of 1003 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
davidgamez
deleted the
2021-missing-validatorversion-value-from-gtfs-validation-report
branch
2 participants
Summary:
Closes #2021
Expected behavior:
Keep and return a single shared “in‑progress” VersionInfo once resolution starts. Set the current version synchronously before kicking off the background fetch of the latest release. If another request arrives during resolution, it gets the same instance (already carrying currentVersion) instead of an empty one.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything