Skip to content

build: replace upload-release-asset with action-gh-release#2063

Closed
tqpcharlie wants to merge 3 commits intoMobilityData:masterfrom
tqpcharlie:releaseAsset
Closed

build: replace upload-release-asset with action-gh-release#2063
tqpcharlie wants to merge 3 commits intoMobilityData:masterfrom
tqpcharlie:releaseAsset

Conversation

@tqpcharlie
Copy link
Copy Markdown
Contributor

@tqpcharlie tqpcharlie commented Oct 31, 2025

Summary:

This PR replaces the upload-release-asset action with action-gh-release, since the former has been deprecated for almost 5 years now. Fixes #2009

Expected behavior:

See the action-gh-release docs for info on my edits to the Action.

Please make sure these boxes are checked before submitting your pull request - thanks!

- [ ] Run the unit tests with gradle test to make sure you didn't break anything

  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@welcome
Copy link
Copy Markdown

welcome Bot commented Oct 31, 2025

Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:

  • fix: Bug with ssl network connections + Java module permissions.
  • feat: Initial support for multiple @PrimaryKey annotations.
  • docs: update RELEASE.md with new process
    To get this PR to the finish line, please do the following:
  • Read our Contribution Guidelines
  • Follow Google Java style coding standards
  • Include tests when adding/changing behavior
  • Include screenshots

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 31, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@davidgamez davidgamez requested a review from jcpitre October 31, 2025 14:32
@jcpitre
Copy link
Copy Markdown
Contributor

jcpitre commented Nov 19, 2025

@tqpcharlie Thanks for the contribution.
Since it's kind of difficult to test this unless we do an actual release, if you agree we will wait for the next release to merge this.

@tqpcharlie tqpcharlie closed this by deleting the head repository Jan 6, 2026
@tqpcharlie tqpcharlie reopened this Jan 8, 2026
@tqpcharlie
Copy link
Copy Markdown
Contributor Author

Hi all, reopened, sorry for the inconvenience

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release publishing workflow to move away from the deprecated actions/upload-release-asset action and toward softprops/action-gh-release, aligning the repo’s release automation with currently maintained GitHub Actions.

Changes:

  • Replaced the release-asset upload steps for the CLI and GUI JARs with softprops/action-gh-release@v2.
  • Updated upload configuration to use files for artifact selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/publish_assets.yml
Comment thread .github/workflows/publish_assets.yml
Comment thread .github/workflows/publish_assets.yml
@jcpitre
Copy link
Copy Markdown
Contributor

jcpitre commented Mar 9, 2026

@tqpcharlie We ran copilot on the changes and it pointed out some interesting issues.
We intend to release a new version shortly.
You could make the corrections yourself, or if it's not possible I can do them.
Let me know!

@davidgamez davidgamez added this to the 8.0 Release milestone Mar 11, 2026
@jcpitre jcpitre mentioned this pull request Mar 12, 2026
5 tasks
@jcpitre
Copy link
Copy Markdown
Contributor

jcpitre commented Mar 12, 2026

@tqpcharlie Thank you for the contribution!
We copied your branch into MobilityData/gtfs-validator so we could make some changes.
This means we needed a new PR: #2134
I am closing this PR since it's essentially replaced by #2134 .

@jcpitre jcpitre closed this Mar 12, 2026
@tqpcharlie tqpcharlie deleted the releaseAsset branch March 30, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace GitHub action upload-release-asset

6 participants