Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 29, 2026

Change Summary

Having list of tags with nested list of values is okay for limited scope (get only tag values bound to dataset/job/etc). But it's not very convenient for working with unbound list of values - e.g. getting all list of tags in UI will load all existing tag values, even if it's not actually used.

Instead of introducing paginagion of tag values into already paginated tags list. split GET /v1/tags into 2 endpoints - GET /v1/tags returns only tag names (paginated), and GET /v1/tag-values returns only tag values (paginated).

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
data_rentgen/server/services
   dataset.py27196%36
   job.py30196%37
   tag.py31196%44
   tag_value.py23195%32
TOTAL764592487% 

@dolfinus dolfinus marked this pull request as ready for review January 29, 2026 09:59
@dolfinus dolfinus marked this pull request as draft January 30, 2026 14:29
@dolfinus
Copy link
Member Author

It looks like UI doesn't actually need this: MobileTeleSystems/data-rentgen-ui#123

@dolfinus dolfinus closed this Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants