-
Notifications
You must be signed in to change notification settings - Fork 56
Modernize 2025 clean #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Modernize 2025 clean #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct /assets/graphicsfavicon/ to /assets/graphics/favicon/ - Adds missing slash between 'graphics' and 'favicon' in favicon-32x32.png link - Ensures consistent favicon URL structure across all favicon references This fixes the 404 error for the 32x32 favicon on missingmaps.org
- Add debug steps before and after build to check .tmp and _site directories - Look for main.css file location during build process - Investigate why CSS builds locally but not on GitHub Actions
- Remove temporary debug steps from deploy.yml - Ready for merge to publish branch to test CSS deployment
- Check for main.css after build completes - Will help diagnose any CSS build issues in GitHub Actions - Non-disruptive logging only
- Verify critical CSS, JavaScript, and font files exist and have reasonable sizes - Check for essential pages (home, about, beginner, host, blog) - Validate all language versions (en, es, fr, cs) are built - Display build summary with total files and size - Fail deployment if any critical assets are missing - Provides detailed logging for troubleshooting build issues
- Remove redundant local util/ directory that was shadowing Foundation's util files - Fix Foundation Sites util import path in _settings.scss - This was the root cause of main.css not being generated during builds - Sass was failing silently, showing false success while no CSS files were created - Explains why main.css worked locally initially but failed on GitHub Actions
- Use absolute path to Foundation's util/util from node_modules - Resolves the 'Can't find stylesheet to import' error - main.css now generates successfully (312KB) - Critical fix for CSS deployment issue on GitHub Actions - Removes the conflict between local and Foundation util paths
- Correct Spanish navigation URLs to match actual page paths - /es/principiante/ → /es/beginner/ - /es/avanzado/ → /es/advanced/ - /es/terreno/ → /es/field/ - /es/organizar/ → /es/host/ - /es/acercade/ → /es/about/ - /es/eventos/ → /es/events/ - /es/validar/ → /es/validate/ - Correct French navigation URLs to match actual page paths - /fr/debutant/ → /fr/beginner/ - /fr/avance/ → /fr/advanced/ - /fr/terrain/ → /fr/field/ - /fr/organiser/ → /fr/host/ - /fr/apropos/ → /fr/about/ - /fr/evenements/ → /fr/events/ - /fr/validation/ → /fr/validate/ - Correct Czech navigation URLs to match actual page paths - /cs/začátečník/ → /cs/beginner/ - /cs/pokročilý/ → /cs/advanced/ - /cs/terén/ → /cs/field/ - /cs/organizuj/ → /cs/host/ - /cs/o-projektu/ → /cs/about/ - /cs/akce/ → /cs/events/ - /cs/validuj/ → /cs/validate/ All navigation links now point to existing pages built by Jekyll Polyglot
- Fix remaining Czech navigation URLs: - /cs/akce/ → /cs/events/ - /cs/organizuj/ → /cs/host/ - Repair corrupted YAML structure in img-alt section - Ensure all navigation links work correctly
Member
Author
|
cleaning up some silly git mistakes and error fixing translations. Apparently when you upgrade everything some things break. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.