Major update to version 1.0#241
Open
SimplicityGuy wants to merge 69 commits intoMiserlou:masterfrom
SimplicityGuy:master
Open
Major update to version 1.0#241SimplicityGuy wants to merge 69 commits intoMiserlou:masterfrom SimplicityGuy:master
SimplicityGuy wants to merge 69 commits intoMiserlou:masterfrom
SimplicityGuy:master
Conversation
…returned from the SoundClound API.
…ents. Adding TODOs.
…ore comprehensive.
…ly checking for None.
…specific error that can happen.
…ingle track from SoundCloud.
This was referenced Aug 1, 2020
Author
|
@Miserlou bump. I'd like to get a second set of eyes on the changes here. I know it's a big change. |
This was referenced Aug 1, 2020
Closed
Closed
Closed
|
It solved issues with filenames but broke the ability to download from likes apparently. Here is an error on the UTF-8 test playlist I made: Here is the error with likes: Thank you for the good work on the tool fixing those previous issues ! |
|
Currently resorting to https://github.com/flyingrub/scdl but relieved to see this project is still going Sincerely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of major changes in this release!
Build/CI changes:
flake8linter andblackformatting.nosetest format topytest.Breaking changes:
Fixes: