Adds --plays option to add play count#183
Open
alexgorbatchev wants to merge 2 commits intoMiserlou:masterfrom
Open
Adds --plays option to add play count#183alexgorbatchev wants to merge 2 commits intoMiserlou:masterfrom
--plays option to add play count#183alexgorbatchev wants to merge 2 commits intoMiserlou:masterfrom
Conversation
Owner
|
Good idea but Travis isn't happy.. |
Author
|
I fixed the tests that my PR broke. Other failures currently happen on |
|
@alexgorbatchev new long playlist https://soundcloud.com/muloka/sets/burning-man-2017 |
alexgorbatchev
force-pushed
the
master
branch
from
28fdcda to
4dfa1a3
Compare
…ownloading from SoundCloud playlists. Why? Because sometimes when you want to archive a very long play list (eg https://soundcloud.com/muloka/sets/burning-man-2016) it could be handy to be able to sort files by "popularity". To achieve that, `--plays` option adds play count at the moment of the download as the first thing in the file name. If you want to resync the playlist, files that were downloaded already won't be redownloaded with new play count. At the same time, existing file's play count won't be updated either.
alexgorbatchev
force-pushed
the
master
branch
from
28ea770 to
3553250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? Because sometimes when you want to archive a very long play list (eg https://soundcloud.com/muloka/sets/burning-man-2016) it could be handy to be able to sort files by "popularity". To achieve that,
--playsoption adds play count at the moment of the download as the first thing in the file name.If you want to resync the playlist, files that were downloaded already won't be redownloaded with new play count. At the same time, existing file's play count won't be updated either.
I don't know if the feature would be interesting to merge, but I thought I would share it anyways.