Skip to content

Conversation

@domfournier
Copy link

@domfournier domfournier commented Jun 17, 2025

GEOPY-2155 - .omf exporter ndvs not read correctly by leapfrog

@github-actions github-actions bot changed the title GEOPY-2155 GEOPY-2155: .omf exporter ndvs not read correctly by leapfrog Jun 17, 2025
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (f4fd643) to head (dd90a06).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
+ Coverage    93.23%   93.28%   +0.04%     
===========================================
  Files           28       28              
  Lines         1478     1489      +11     
===========================================
+ Hits          1378     1389      +11     
  Misses         100      100              
Files with missing lines Coverage Δ
omf/fileio/geoh5.py 93.33% <100.00%> (+0.05%) ⬆️
tests/convert_volume_test.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust you on the logic.

Missing testing the output for the int values

@MatthieuCMira MatthieuCMira self-requested a review June 18, 2025 17:23
MatthieuCMira
MatthieuCMira previously approved these changes Jun 18, 2025
Copy link

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@domfournier domfournier merged commit 1c97986 into develop Jun 18, 2025
12 checks passed
@domfournier domfournier deleted the GEOPY-2155b branch June 18, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants