GEOPY-2363: geoh5py.data.visual_parameters.colour returns BGR not RGB

geoh5py/data/visual_parameters.py

@@ -21,6 +21,7 @@
 from __future__ import annotations
 
 import xml.etree.ElementTree as ET
+from collections.abc import Sequence
 
 import numpy as np
 
@@ -101,19 +102,24 @@ def colour(self) -> None | list:
 
         c_string = (int(element.text)).to_bytes(4, byteorder="little").hex()
 
-        return [int(c_string[i : i + 2], 16) for i in range(0, 8, 2)][:3]
+        # Flip the colour order from BGR to RGB
+        return [int(c_string[i : i + 2], 16) for i in range(0, 8, 2)][2::-1]
 
     @colour.setter
-    def colour(self, rgb: list | tuple | np.ndarray):
+    def colour(self, rgb: Sequence):
         if (
-            not isinstance(rgb, (list, tuple, np.ndarray))
+            not isinstance(rgb, Sequence)
             or len(rgb) not in [3, 4]
             or not all(isinstance(val, int) for val in rgb)
         ):
             raise TypeError("Input 'colour' values must be a list of 3 or 4 integers.")
 
+        rgb = list(rgb)
         if len(rgb) == 3:
-            rgb = list(rgb) + [255]
+            rgb += [255]
+
+        # Flip the colour order from RGB to BGR
+        rgb = rgb[2::-1] + [rgb[3]]
 
         byte_string = "".join(f"{val:02x}" for val in rgb)
         byte_string.join(f"{255:02x}")  # alpha value

tests/visual_parameters_test.py

@@ -59,11 +59,11 @@ def test_visual_parameters(tmp_path, caplog):
         assert copy.visual_parameters.colour == viz_params.colour
 
         # Repeat with known color
-        points.visual_parameters.colour = [0, 255, 0]
+        points.visual_parameters.colour = [255, 0, 0]  # Should be red
 
     with Workspace(h5file_path) as workspace:
         points = workspace.get_entity(name)[0]
-        assert points.visual_parameters.colour == [0, 255, 0]
+        assert points.visual_parameters.colour == [255, 0, 0]
 
         viz_params = points.visual_parameters
         viz_params_b = viz_params.copy()