GEOPY-2632: Simplify the BaseForm.infer method #829
+225
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # geoh5py/shared/utils.py
github-actions
bot
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #829 +/- ##
========================================
Coverage 91.15% 91.16%
========================================
Files 113 113
Lines 9999 10017 +18
Branches 1883 1873 -10
========================================
+ Hits 9115 9132 +17
- Misses 468 473 +5
+ Partials 416 412 -4
🚀 New features to boost your workflow:
|
domfournier
reviewed
Jan 14, 2026
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
…n check in favor of double return statements.
domfournier
reviewed
Jan 16, 2026
Contributor
domfournier
left a comment
domfournier
left a comment
There was a problem hiding this comment.
The logic is pretty complicated - I have flashbacks from InputFile.
Can you comment the lines for the different cases?
domfournier
reviewed
Jan 19, 2026
domfournier
reviewed
Jan 19, 2026
Contributor
domfournier
left a comment
domfournier
left a comment
There was a problem hiding this comment.
Looks great. Minor comments below
| strict = isinstance(value, (int, float, bool)) | ||
| validation.validate_python(value, strict=strict) | ||
| filtered_candidates.append(candidate) | ||
| except ValidationError: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-2632 - Simplify the BaseForm.infer method