fix: Ensure savings are correct when max_snippet_lines is used#206
Open
Pringled wants to merge 2 commits into
Open
fix: Ensure savings are correct when max_snippet_lines is used#206Pringled wants to merge 2 commits into
Pringled wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Confidence Score: 5/5Safe to merge; the change is a targeted stats-accounting fix with no impact on search results or user-facing output. The fix correctly threads max_snippet_lines through the call chain and the three-way conditional in save_search_stats (None, 0, positive) is logically sound and matches the truncation already applied by format_results. The ge=0 guard added to the MCP parameters is a small defensive improvement. No existing behavior is altered beyond the savings counter. No files require special attention. Reviews (1): Last reviewed commit: "add ge=0" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
max_snippet_lineswas used, savings were undercounted. This PR fixes that.