Skip to content

fix(ci): add 7 missing repos to REPO_MODULE mapping (W-04)#52

Merged
lml2468 merged 1 commit into
mainfrom
fix/w04-repo-module-mappings
May 31, 2026
Merged

fix(ci): add 7 missing repos to REPO_MODULE mapping (W-04)#52
lml2468 merged 1 commit into
mainfrom
fix/w04-repo-module-mappings

Conversation

@lml2468
Copy link
Copy Markdown
Contributor

@lml2468 lml2468 commented May 31, 2026

Summary

Fixes W-04: the REPO_MODULE mapping in auto-add-to-project.yml was missing entries for 7 caller repos, so items created from those repos landed on the org Project board without a Module value set.

Missing repos added

Repo Module Option ID
claw-channel-octo adapters 68365b07
octo-android android 39fb6657
octo-cli cli 9ac9e614
octo-daemon-cli cli 9ac9e614
octo-im server 5f815fea
octo-ios ios f06b0979
octo-version-sync infra ae83be09

The ios and android Board single-select options were created to back the new mappings.

Other changes

  • Sorted REPO_MODULE alphabetically for easier maintenance and to spot duplicates / gaps.
  • Updated the Known callers header comment from 8 → 19 repos to reflect every repository that currently calls this reusable workflow.

Test plan

  • Open an issue in octo-cli (or any of the 7 newly-mapped repos) and confirm the resulting Project item gets the correct Module value set.
  • Open an issue in an already-mapped repo (e.g. octo-server) and confirm behavior is unchanged.

Added mappings for octo-im (→ server), octo-cli (→ cli),
octo-daemon-cli (→ cli), octo-ios (→ ios), octo-android (→ android),
octo-version-sync (→ infra), claw-channel-octo (→ adapters).

Sorted REPO_MODULE alphabetically for maintainability.
Updated Known callers from 8 to 19 repos.
@lml2468 lml2468 requested a review from a team as a code owner May 31, 2026 14:23
Copy link
Copy Markdown
Contributor Author

@lml2468 lml2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — PR #52 (.github) @ 1f6944f

Verdict: APPROVED

Pure data addition — 7 missing repos added to REPO_MODULE mapping in auto-add-to-project.yml:

Repo Module Module ID Consistent with
claw-channel-octo adapters 68365b07 octo-adapters, openclaw-channel-octo ✓
octo-android android 39fb6657 new module ✓
octo-cli cli 9ac9e614 — ✓
octo-daemon-cli cli 9ac9e614 octo-cli ✓
octo-im server 5f815fea octo-server ✓
octo-ios ios f06b0979 new module ✓
octo-version-sync infra ae83be09 .github, community ✓

All module assignments are logically correct. Mapping sorted alphabetically. Known callers comment updated from 8 → 19, matches REPO_MODULE keys exactly. No logic changes.

CI all green (actionlint, sanity, add-to-project). No blocking or non-blocking issues.

Copy link
Copy Markdown

@Jerry-Xin Jerry-Xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is relevant to Mininglamp-OSS/.github and the mapping change is scoped correctly to the shared Project automation.

💬 Non-blocking

  • 🔵 Suggestion: .github/workflows/auto-add-to-project.yml labels this list as “Known callers”, but it includes .github (direct trigger). Consider renaming it to “Known source repositories” to avoid a small terminology mismatch.
  • 🟡 Warning: .github/workflows/auto-add-to-project.yml shows callers using @v1. If real caller workflows are pinned to that tag, this fix will not take effect for them until the v1 ref is updated or callers move to a ref containing this commit.

✅ Highlights

  • The PR passes the project relevance gate: it modifies shared GitHub Actions automation owned by this repository.
  • The new REPO_MODULE entries are consistent with the existing mapping style and use static option IDs through GraphQL variables rather than string interpolation.
  • Sorting the mapping and expanding the known-source comment improves maintainability and makes future gaps easier to spot.

I found no blocking logic, security, performance, or style issues in the changed workflow.

Copy link
Copy Markdown

@yujiawei yujiawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — PR #52 (.github)

Verdict: APPROVED

A focused, low-risk fix to the REPO_MODULE mapping in the reusable auto-add-to-project.yml workflow. I verified every mapping against the live Project board and the data is correct.

Verification

Check Result
All 7 newly-added repos exist in the org and are not archived
claw-channel-octo vs openclaw-channel-octo are distinct repos, both correctly → adapters ✅ (not a typo — two separate repos)
All 19 option IDs resolve to existing Module single-select options on the board
Each inline comment label matches the live option name for its ID
ios / android options now exist on the board to back the new mappings
REPO_MODULE keys (19) match the Known callers (19 repos) header list exactly
Alphabetical sort is correct, no duplicate keys
Mapping is the only behavioral surface touched; lookup logic and security-sensitive pull_request_target / no-checkout posture are unchanged

Option-ID spot check against the board (PVTSSF_lADOEOckHc4BXcvHzhSpg48): 5f815fea=server, 9ac9e614=cli, 39fb6657=android, f06b0979=ios, ae83be09=infra, 68365b07=adapters — all consistent with the comments in the diff.

Findings

No P0/P1 issues. The change does exactly what it claims (W-04) with no regressions to existing entries.

Nits / non-blocking

  1. octo-imserver: this routes the IM repo to the server Module rather than a dedicated value. Looks intentional (IM treated as part of the server backend), but worth a quick confirm that there isn't a more specific Module it should land in. Not a blocker.
  2. Test plan unchecked: the two manual-verification checkboxes in the PR body are still empty. Since the mapping is data-only and verified against the live board, this is fine to merge, but checking one real repo (e.g. octo-cli) post-merge would close the loop.

The alphabetical re-sort plus the expanded Known callers header are good maintainability improvements that make future gaps easy to spot.

@lml2468 lml2468 merged commit 369d79a into main May 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants