chore: remove orphan reusable workflow octo-pr-feed.yml (W-01)#50
Conversation
This reusable workflow was created to handle PR events and notify Octo IM, but audit (W-01) confirmed no repository in Mininglamp-OSS calls it. Zero callers found across all 18 active repos. Removing the dead code to keep the workflow directory clean.
lml2468
left a comment
There was a problem hiding this comment.
Review — PR #50 (.github) @ 1141d6b
Verdict: APPROVED
Pure deletion of the orphaned reusable workflow octo-pr-feed.yml (198 lines). All four caller repos (claw-channel-octo, octo-version-sync, octo-daemon-cli, octo-im) have already deleted their callers and consolidated into octo-pr-result-notify.yml. Verified: no remaining references on main across all four repos.
CI all green (actionlint, sanity, add-to-project).
No blocking or non-blocking issues.
yujiawei
left a comment
There was a problem hiding this comment.
Code Review — PR #50 (.github)
Summary
This PR removes a single orphan reusable workflow, .github/workflows/octo-pr-feed.yml (−198 / +0, 1 file). The change is a clean dead-code deletion with no functional impact. Approved.
1. Verification of the orphan claim ✅
The PR's core claim is that octo-pr-feed.yml is a reusable workflow with zero callers. I verified this independently against the organization rather than trusting the PR description:
- An org-wide code search for the reusable-call path
uses: Mininglamp-OSS/.github/.github/workflows/octo-pr-feed.ymlreturns no results — there are nouses:invocations of this workflow anywhere. - The only matches for the string
octo-pr-feedacross the org are in comments insidelabeler.ymlandauto-add-to-project.yml(e.g. "the pattern used by auto-add-to-project.yml and octo-pr-feed.yml"). These are documentation references to a naming convention, not functional dependencies — removing the workflow does not break them. - By contrast, the workflows the PR names as the live replacements —
octo-pr-review-feed.ymlandocto-pr-result-notify.yml— do have realuses:callers wired up across the active repos, confirming PR-event notification is still covered.
Conclusion: the workflow is genuinely an orphan, and deleting it is safe.
2. Issues found
No P0/P1 issues. Deleting an uncalled workflow_call-only reusable workflow cannot break any pipeline (it has no push/pull_request triggers of its own and nothing invokes it).
3. Suggestions (non-blocking)
- P2 / nit: A handful of comment references to
octo-pr-feed.ymlremain in other repos'labeler.yml/auto-add-to-project.ymlfiles (used as an example of a shared naming pattern). They are now slightly stale and could mislead a future reader into thinking the workflow still exists. Not a blocker for this PR, but worth a quick follow-up sweep to update or drop those comments so the audit trail stays clean.
4. Additional observations
- The deleted workflow had good security hygiene (
permissions: {}, input sanitization, an API base-URL allowlist, group-id format validation). None of that is lost in a way that matters, since the same protections live in the active replacement workflows — but it's a useful reference point if those replacements are ever re-audited.
Overall: a well-scoped, well-verified cleanup. No changes required.
Jerry-Xin
left a comment
There was a problem hiding this comment.
Summary: This PR is in scope for Mininglamp-OSS/.github and safely removes an unreferenced reusable workflow.
💬 Non-blocking
- 🔵 Suggestion: Org-wide search still finds comment-only references to
octo-pr-feed.yml, for exampleMininglamp-OSS/octo-web .github/workflows/labeler.yml:11andMininglamp-OSS/octo-version-sync .github/workflows/auto-add-to-project.yml:14. They are not callers, but cleaning them up in follow-up PRs would avoid stale documentation.
✅ Highlights
- Project relevance gate passed: deleting
.github/workflows/octo-pr-feed.yml:1is directly within this repository’s reusable workflow ownership. - No local references remain in this repo.
- External code search found no
uses:calls toMininglamp-OSS/.github/.github/workflows/octo-pr-feed.yml, so the deletion does not appear to break active reusable workflow consumers. - No test changes are needed for this dead workflow removal.
Summary
Remove the orphan reusable workflow
octo-pr-feed.ymlidentified as W-01 in the workflow audit.Audit Finding (W-01)
.github/workflows/octo-pr-feed.ymlMininglamp-OSS/.github/.github/workflows/octo-pr-feed.ymlImpact
.githubworkflow directory clean and auditableWhat Was Removed
The workflow was designed to notify Octo IM on PR events (opened, closed, merged, etc.) via a Python script. This functionality is currently handled by
octo-pr-review-feed.ymlandocto-pr-result-notify.ymlin individual repos.