Add ability to set different text size#64
Open
Mathbl wants to merge 1 commit intoMiguelCatalan:developfrom
Open
Add ability to set different text size#64Mathbl wants to merge 1 commit intoMiguelCatalan:developfrom
Mathbl wants to merge 1 commit intoMiguelCatalan:developfrom
Conversation
Owner
|
Awesome! I will check it today and merge it ASAP! |
|
rather that textSize, use |
Owner
|
Sorry for the delay, I've been full of shit for the last few months. In the next days I will check all the PRs and give you an answer. |
|
@MiguelCatalan is this ever going to get merged? |
|
hello @MiguelCatalan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is working for my use case. I'm able to set
<item name="android:textSize">@dimen/font_size_toolbar</item>where font_size_toolbar is 20sp.I was hesitating to make a variable for
DEFAULT_TEXT_SIZEinMaterialSearchView.javae.g.:
public static final int DEFAULT_TEXT_SIZE = 15;then we can do:
setTextSize(a.getDimensionPixelSize(R.styleable.MaterialSearchView_android_textSize, DEFAULT_TEXT_SIZE));But tbh, i'm not sure if it's needed.