refactor: simplify public/images/banner.svg for easier manual editing#347
Open
mskiptr wants to merge 16 commits intoMightyCreak:mainfrom
Open
refactor: simplify public/images/banner.svg for easier manual editing#347mskiptr wants to merge 16 commits intoMightyCreak:mainfrom
mskiptr wants to merge 16 commits intoMightyCreak:mainfrom
Conversation
None of them can be used with a <path> element. Best reviewed using `git show --word-diff-regex=.`
Best reviewed using `git show --word-diff-regex=.`
Best reviewed using `LESS=-RS git show`
Best reviewed using `git show --word-diff-regex=.`
Best reviewed using `git show --color-moved`
These were either already the default, or are inherited from the parent element. Best reviewed using `git show --word-diff-regex=.`
Best reviewed using `git show --word-diff-regex='[A-Za-z0-9]+'`
Best reviewed using `LESS=-RS git show`
Best reviewed using `git show --word-diff`
Best reviewed using `LESS=-RS git show --color-moved`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes about 20 KiB of unnecessary fluff from the SVG banner logo (out of ~40 KiB in total). None of that should change the visual appearance of the logo, though.
To ease the review process I strived to keep every commit narrowly focused. In cases where the default line diffs were not readable, I also included examples of git commands that make the actual change clearly visible.
That doesn't mean much review is actually needed here – the resulting SVG looks exactly the same as the original and passing it through the W3C's validation tool no longer raises any errors nor warnings (before my changes, it used to complain about a few old Inkscape things).