Open
Conversation
Co-authored-by: Angel Malavar <angel.malavar@gmail.com>
ApiAuth v1 has insecure defaults and uses deprecated Faraday features which lead to test spam. This bumps it to ~>2.0, because that allows for versions which use Faraday correctly, and fixes the security vulnerabilities. Example of the Faraday deprecation warning: ``` WARNING: `Faraday::Request#method` is deprecated; use `#http_method` instead. It will be removed in or after version 2.0. `Faraday::Request#method` called from /Users/josh/.gem/ruby/3.0.2/gems/api-auth-2.0.0/lib/api_auth/request_drivers/faraday.rb:24:in `populate_content_md5' ``` Link to v2.0 in the changelog: https://github.com/mgomes/api_auth/blob/master/CHANGELOG.md#200-2016-05-11 Link to the security vulnearability: https://github.com/mgomes/api_auth/blob/master/CHANGELOG.md#140-2015-12-16 Co-authored-by: Angel Malavar <angel.malavar@gmail.com>
Author
|
@tellodaniel said you were intentionally avoiding the upgrade because it was breaking something. The breaking change was that it includes the HTTP method when signing, so that a
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pry to Gemfile
Add pry to Gemfile so you can
bundle exec rspec(if you don'tbundle exec, you could get random versions of the gems, but if you do, then it can't loadpryas it's not specified as a development dependency)Update ApiAuth to
~> 2.0ApiAuth v1 has insecure defaults and uses deprecated Faraday features which lead to test spam. This bumps it to ~>2.0, because that allows for versions which use Faraday correctly, and fixes the security vulnerabilities.
Example of the Faraday deprecation warning from Mifiel's test suite:
Co-authored-by: Angel Malavar angel.malavar@gmail.com