refactor: remove src directory and update config paths#21
refactor: remove src directory and update config paths#21francescopausellii wants to merge 3 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's directory structure by eliminating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request primarily refactors import paths across the codebase, including updates to configuration files like .oxfmtrc.json, drizzle.config.ts, and tsconfig.json, reflecting a likely change in the project's directory structure and consolidation of authentication-related files. A critical performance issue was identified in app/page.tsx, where importing useSession from lib/auth/client.ts violates Rule 2.1 (bundle-barrel-imports) of the repository's style guide. This barrel file import can unnecessarily increase bundle size by including unused client-side authentication functions, and it is recommended to refactor for more granular imports to optimize tree-shaking.
cecco25
left a comment
There was a problem hiding this comment.
- Format
vitest.config.mts - Update
READMEto match current architecture
The PR introduces a cleaner and lighter starting architecture compared to the original src directory, and also moves the core authentication logic of better-auth to a more shared location