Conversation
Contributor
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
with theses changes I'll be able to run test but it's will fail because node.js need .ts file ext
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Signed-off-by: Dina Berry (MSFT) <diberry@microsoft.com>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Signed-off-by: Dina Berry (MSFT) <diberry@microsoft.com>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Signed-off-by: Dina Berry (MSFT) <diberry@microsoft.com>
…nto node-test-runner
Contributor
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
here with theses changes you il have a correct test suite
sinedied
approved these changes
Mar 18, 2025
Contributor
sinedied
left a comment
sinedied
left a comment
There was a problem hiding this comment.
Great work here! Just put a few "nit" comments, nothing important
Co-authored-by: Yohan Lasorsa <noda@free.fr> Signed-off-by: Dina Berry (MSFT) <diberry@microsoft.com>
maorleger
reviewed
Mar 24, 2025
Contributor
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
Haven't gotten to vitest yet but a few comments so far - feel free to ask if anything is unclear
In general I love seeing vitest and node test runner getting attention 👍
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.