Skip to content

Fix/module 07 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tasotasoso wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/module 07 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8d5df
fix path for javascript file
Apr 27, 2021
3196cbe
Fixed outDir to match other exercises of module07.
Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/module-07/m07-end/module07.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<body>
<h1>Test JavaScript</h1>
<p id="date"></p>
<p>This page calls the script module08_main.js and is used for testing.</p>
<script src=".\build\module08_main.js"></script>
<p>This page calls the script module07_main.js and is used for testing.</p>
<script src=".\module07_main.js"></script>
<noscript>You need to enable JavaScript to view the full site.</noscript>
</body>
</html>
2 changes: 1 addition & 1 deletion code/module-07/m07-end/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
// "sourceMap": true, /* Generates corresponding '.map' file. */
// "outFile": "./", /* Concatenate and emit output to single file. */
"outDir": "build", /* Redirect output structure to the directory. */
// "outDir": "./", /* Redirect output structure to the directory. */
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
// "composite": true, /* Enable project compilation */
// "tsBuildInfoFile": "./", /* Specify file to store incremental compilation information */
Expand Down
4 changes: 2 additions & 2 deletions code/module-07/m07-start/module07.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<body>
<h1>Test JavaScript</h1>
<p id="date"></p>
<p>This page calls the script module08_main.js and is used for testing.</p>
<script src=".\build\module08_main.js"></script>
<p>This page calls the script module07_main.js and is used for testing.</p>
<script src=".\module07_main.js"></script>
<noscript>You need to enable JavaScript to view the full site.</noscript>
</body>
</html>
2 changes: 1 addition & 1 deletion code/module-07/m07-start/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
// "sourceMap": true, /* Generates corresponding '.map' file. */
// "outFile": "./", /* Concatenate and emit output to single file. */
"outDir": "build", /* Redirect output structure to the directory. */
// "outDir": "./", /* Redirect output structure to the directory. */
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
// "composite": true, /* Enable project compilation */
// "tsBuildInfoFile": "./", /* Specify file to store incremental compilation information */
Expand Down