Skip to content

Update howto-network-fabric-quality-of-service.md#4340

Open
rkaraddi wants to merge 1 commit into
MicrosoftDocs:mainfrom
rkaraddi:rkaraddi/qosDocChanges
Open

Update howto-network-fabric-quality-of-service.md#4340
rkaraddi wants to merge 1 commit into
MicrosoftDocs:mainfrom
rkaraddi:rkaraddi/qosDocChanges

Conversation

@rkaraddi

Copy link
Copy Markdown

Fixing errors in the QoS doc

@prmerger-automator

Copy link
Copy Markdown
Contributor

@rkaraddi : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@prmerger-automator prmerger-automator Bot requested a review from dougbristow June 18, 2026 22:39
@prmerger-automator

Copy link
Copy Markdown
Contributor

@rkaraddi : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 084e9fa:

✅ Validation status: passed

File Status Preview URL Details
operator-nexus/howto-network-fabric-quality-of-service.md ✅Succeeded

For more details, please refer to the build report.

@bartpinto bartpinto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few recommendations below.

- Fabric must be in a state that allows updates (not in an immutable provisioning phase).


## Option 1—Azure CLI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says "Option 1" but are there other options? I think it can be enabled at time of fabric create as well.

@@ -33,16 +33,18 @@

### Enable configuration lock:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be before the update command is run.

## Prerequisites

- Use supported API and Fabric version.
- Fabric must be in a state that allows updates (not in an immutable provisioning phase).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we describe configuration locked as an example? Are there other states that allow update?

--resource-group XXX_RESOURCE_GROUP \
--resource-name XXX_FABRIC_NAME
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note that the commit will remove the configuration lock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants