-
Notifications
You must be signed in to change notification settings - Fork 47
automate observatory previews #5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,13 +7,16 @@ on: | |
| paths: | ||
| - "observatory/**" | ||
| - ".github/workflows/**" | ||
| pull_request: | ||
| types: [opened, synchronize, closed] | ||
| workflow_dispatch: {} | ||
|
|
||
| jobs: | ||
| build-and-deploy: | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| uses: ./.github/workflows/_build-and-deploy.yml | ||
| with: | ||
|
|
@@ -22,3 +25,5 @@ jobs: | |
| namespace: observatory | ||
| release: observatory | ||
| chart: ./devops/charts/observatory | ||
| preview_helm_values: "--set host=${{ (github.event_name == 'pull_request' && github.event.action != 'closed') && format('observatory-preview-{0}.softmax-research.net', github.event.pull_request.number) || '' }}" | ||
| preview_host: "${{ (github.event_name == 'pull_request' && github.event.action != 'closed') && format('observatory-preview-{0}.softmax-research.net', github.event.pull_request.number) || '' }}" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This has to be explicit: |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a PR is closed,
DELETE_PREVIEWbecomes true and thehelm deletestep runs, but thisConfigure EKSstep only runs formainorBUILD_PREVIEW(open PRs). On apull_request: closedevent, the kubeconfig/context is never set up, so the delete will fail and leave preview releases behind. Consider including the delete path (e.g.,env.DELETE_PREVIEW == 'true') in the EKS configure condition or skipping deletion without config.Useful? React with 👍 / 👎.