Fix no fall disconnect crashing occur#6253
Merged
Wide-Cat merged 1 commit intoMeteorDevelopment:masterfrom Mar 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fixes bug where if the user goes through with a server disconnect or reconnect, mc.player may be null when using NoFall module, crashing the client. This can occur when other modules from other plugins use nofall and tries to use nofall on server disconnect; crashing the client. This error is caused by Meteor, and not these clients and is just because of there being no check. This just fixes the error that I encountered in crash.
Crash log can be seen here:
Related issues
Mention any issues that this pr relates to.
How Has This Been Tested?
On a singleplayer world, and on a multiplayer world (Minehut), when force-disconnecting while NoFall is active.
Checklist: