EnchantmentOptimizer#6076
Draft
Big-Iron-Cheems wants to merge 5 commits intoMeteorDevelopment:masterfrom
Draft
Conversation
I think it works, but can be improved for sure :)
NOTE: there is still a discrepancy in the calculation we make, need to figure out why.
Collaborator
Author
|
The command I am using to test this is: At the moment there seems to be a discrepancy between my algorithm and the website one. Work is needed to find out why, relevant sources for the site impl are:
|
`removeExpensiveCandidates` should iterate on sorted keys for proper filtering.
"Explode" the item name to show applied enchants and named item for better context.
Collaborator
Author
|
At this point I believe it works as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds a command to calculate the optimal enchant order of an item given a list of enchant-level pairs.
Roughly based on https://github.com/iamcal/enchant-order for the calculation logic.
I think it works, but can be improved for sure :)
Related issues
None.
How Has This Been Tested?
Very rough testing, need more eyes on this.
Checklist: