-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Translations, but better #5862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Translations, but better #5862
Conversation
Reorganised the translation files and keys. Lots of work still to be done to change our hardcoded strings into translatable ones. We should no longer be susceptible to detection by servers using the translation exploit.
…d by the translation system
Translations will be automatically updated when the user changes their language.
Adds a label in the bottom right corner of the modules screen that can be clicked on to give translation information.
This includes command exceptions and info/warning/error messages. Still more to be done for commands. This is a bit of a rough draft, if you have any ideas on how better to name or format this, open an issue or message me.
|
I have the feeling that this will still take some time. Maybe you should still add ExploitPreventer. Liquid Bounce will also start using it: CCBlueX/LiquidBounce#7397 There are no disadvantages in using it. |
We use our own translation system similar to this PR, which makes it irrelevant whether we prevent translation key detection or not. This does not affect how the game works, while keeping Meteor safe from detection. Also, sometimes you want the server to know that a mod is present, but you clearly don't want it to know that you have a hacked client installed. This is not yet possible to configure using Exploit Preventer. |
yes I know that you have your own translation system. I will add a way for configuring the mods but it will take some time. |
Type of change
Description
MeteorLanguage, (still unused)MeteorAddon#provideLanguagewith automatic registration, following fabric-resource-loader-v0's functionalityMeteorAddon#idCommandsCommandandmeteor.command.wasp.info.targetHow Has This Been Tested?
The J
Checklist: