Skip to content

Conversation

@Bekiboo
Copy link
Collaborator

@Bekiboo Bekiboo commented Jan 19, 2026

add W3DS.svg for both eCurrency and eReputation & fix eid Wallet link for eCurrency

Description of change

Issue Number

Closes #679

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features
    • Login screen now displays clickable app store links for quick app access
    • App store links are intelligently optimized for Android and iOS devices, directing users to the correct app marketplace

✏️ Tip: You can customize this high-level summary in your review settings.

@Bekiboo Bekiboo self-assigned this Jan 19, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

The PR adds clickable app store links to the eCurrency login screen and updates the app store URL detection logic. The login UI now includes emphasized links to app store URLs for both mobile and desktop flows, with getAppStoreLink() updated to return platform-specific URLs based on user agent detection (Android → Google Play, iOS → Apple App Store, fallback → Google Play).

Changes

Cohort / File(s) Summary
Login Screen UI Updates
platforms/eCurrency/client/src/components/auth/login-screen.tsx
Replaces plain "eID App" text with clickable links to app store URLs using getAppStoreLink(); mobile flow displays "eID Wallet App" link while desktop shows link within QR code scanning instructions
Platform-Specific App Store Detection
platforms/eCurrency/client/src/lib/utils/mobile-detection.ts
Converts getAppStoreLink() from fixed Apple App Store URL to user agent-based resolver supporting Android (Google Play), iOS/iPad/iPhone/iPod (Apple App Store), with Google Play fallback
Dependencies
package.json
Minor dependency updates (+5/-6 changes)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • fix: include link for eID App #653 — Similar code-level change replacing plain "eID App" text with clickable app store link in pictique +page.svelte, using the same getAppStoreLink() utility function for app store URL resolution

Suggested reviewers

  • coodos
  • sosweetham
  • xPathin

Poem

🐰 A link to the store, now shiny and bright!
Android or Apple, we get it just right,
App wallets and QR codes, perfectly lined,
The eCurrency journey, so cleverly designed! 📱✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Out of Scope Changes check ❓ Inconclusive The raw summary shows changes to login-screen.tsx and mobile-detection.ts but the PR description mentions W3DS.svg additions which are not detailed in the provided code summary. Verify that all mentioned W3DS.svg files are properly added and that no unrelated changes exist outside the scope of issue #679.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: adding W3DS logo and fixing eID App link for eCurrency and eReputation.
Description check ✅ Passed The description follows the template with issue number, type of change, and completed checklist items. The key objectives are clearly stated.
Linked Issues check ✅ Passed The PR addresses both requirements from issue #679: implements eID App link with platform-specific detection [#679] and establishes the foundation for W3DS logo integration [#679].

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Bekiboo Bekiboo marked this pull request as ready for review January 19, 2026 17:19
@Bekiboo Bekiboo requested a review from coodos as a code owner January 19, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] eCurrency start page missing market link and W3DS logo

2 participants