[WIP] Feature/item persister and retriever

[discordier]

Description

This feature extracts the database interfacing routines into separate classes.

This is currently work in progress.

Checklist

• Read and understood the CONTRIBUTING guidelines
• Created tests, if possible
• All tests passing
• Extended the README / documentation, if necessary
• Added myself to the @authors in touched PHP files
• Checked the changes with phpcq and introduced no new issues

[discordier]

we might want to cherry-pick 2798cd6 here.

[zonky2]

• Update or New and save item at BE: works fine (fix FR: Item persister and retriever #1097 (comment))

[zonky2]

test for #1005 with translated_text: the empty "zomby cells" live on

@discordier in my opinion, we should implement the check to empty values at

core/src/MetaModels/Attribute/TranslatedReference.php

Lines 316 to 340 in bd9e359

	public function setTranslatedDataFor($arrValues, $strLangCode)
	{
	$objDB = $this->getMetaModel()->getServiceContainer()->getDatabase();
	// First off determine those to be updated and those to be inserted.
	$arrIds = array_keys($arrValues);
	$arrExisting = array_keys($this->getTranslatedDataFor($arrIds, $strLangCode));
	$arrNewIds = array_diff($arrIds, $arrExisting);
	// Update existing values.
	$strQuery = 'UPDATE ' . $this->getValueTable() . ' %s';
	foreach ($arrExisting as $intId) {
	$arrWhere = $this->getWhere($intId, $strLangCode);
	$objDB->prepare($strQuery . ($arrWhere ? ' WHERE ' . $arrWhere['procedure'] : ''))
	->set($this->getSetValues($arrValues[$intId], $intId, $strLangCode))
	->execute(($arrWhere ? $arrWhere['params'] : null));
	}
	// Insert the new values.
	$strQuery = 'INSERT INTO ' . $this->getValueTable() . ' %s';
	foreach ($arrNewIds as $intId) {
	$objDB->prepare($strQuery)
	->set($this->getSetValues($arrValues[$intId], $intId, $strLangCode))
	->execute();
	}
	}

we can use two strategies:

• "clear all an write new" like https://github.com/MetaModels/attribute_translatedurl/blob/master/src/MetaModels/Attribute/TranslatedUrl/TranslatedUrl.php#L214
• "check the value and delete" the correspond rows like https://github.com/MetaModels/attribute_translatedtabletext/blob/master/src/MetaModels/Attribute/TranslatedTableText/TranslatedTableText.php#L246

[zonky2]

=> "check the value and delete"

[richardhj]

Change base branch and reopen?

[discordier]

Something else to do here, we should inject the persister, retriever and resolver via constructor injection.
That way the MetaModel will become more independent and we could swap either component by another one (using doctrine connection i.e.) in the future.

[zonky2]

Why closed?

[discordier]

I deleted the alpha17 branch and github closed the PR then. :/

[zonky2]

o.k.