Skip to content

chore: update a few dependencies #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shane-t wants to merge 3 commits into from
Closed

chore: update a few dependencies #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d148c0
chore: update SSK dependencies
shane-t Nov 28, 2025
e1c2084
chore: cleanup
shane-t Nov 28, 2025
249fcc2
chore: try removing the noble patch
shane-t Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v22.8.0
27 changes: 0 additions & 27 deletions .yarn/patches/@noble-hashes-npm-1.7.1-4106ab26c5.patch
View file
Open in desktop

This file was deleted.

32 changes: 16 additions & 16 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,27 +36,27 @@
"test": "yarn workspaces foreach --parallel --verbose run test"
},
"devDependencies": {
"@metamask/eslint-config": "^12.2.0",
"@metamask/eslint-config-jest": "^12.1.0",
"@metamask/eslint-config-nodejs": "^12.1.0",
"@metamask/eslint-config-typescript": "^12.1.0",
"@metamask/eslint-config": "^14.0.0",
"@metamask/eslint-config-jest": "^14.0.0",
"@metamask/eslint-config-nodejs": "^14.0.0",
"@metamask/eslint-config-typescript": "^14.0.0",
"@typescript-eslint/eslint-plugin": "^5.55.0",
"@typescript-eslint/parser": "^5.55.0",
"depcheck": "^1.4.6",
"eslint": "^8.36.0",
"eslint-config-prettier": "^8.7.0",
"depcheck": "^1.4.7",
"eslint": "^9.26.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-jest": "^27.2.1",
"eslint-plugin-jsdoc": "^40.0.3",
"eslint-plugin-n": "^16.1.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-promise": "^6.1.1",
"prettier": "^2.8.4",
"typescript": "^4.9.5"
"eslint-plugin-jest": "^28.11.0",
"eslint-plugin-jsdoc": "^50.6.17",
"eslint-plugin-n": "^17.18.0",
"eslint-plugin-prettier": "^5.4.0",
"eslint-plugin-promise": "^7.2.1",
"prettier": "^3.5.3",
"typescript": "~5.8.3"
},
"packageManager": "yarn@3.6.3",
"packageManager": "yarn@4.9.1",
"engines": {
"node": ">=18.0.0"
"node": ">=22.8.0"
Copy link

@cursor cursor bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Deleted patch file still referenced in resolutions

The @noble/hashes patch file at .yarn/patches/@noble-hashes-npm-1.7.1-4106ab26c5.patch was deleted, but the resolutions field still references it for three version ranges. Yarn will fail when attempting to apply the non-existent patch during installation, breaking the build process.

Fix in Cursor Fix in Web

},
"resolutions": {
"@noble/hashes@^1.1.2": "patch:@noble/hashes@npm%3A1.7.1#./.yarn/patches/@noble-hashes-npm-1.7.1-4106ab26c5.patch",
Expand Down
12 changes: 6 additions & 6 deletions packages/snap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
"@ethereumjs/tx": "^4.1.2",
"@ethereumjs/util": "^8.0.5",
"@metamask/eth-sig-util": "^7.0.1",
"@metamask/keyring-api": "^21.0.0",
"@metamask/keyring-snap-sdk": "^7.0.0",
"@metamask/snaps-sdk": "^6.19.0",
"@metamask/utils": "^8.1.0",
"@metamask/keyring-api": "^21.2.0",
"@metamask/keyring-snap-sdk": "^7.1.0",
"@metamask/snaps-sdk": "^9.3.0",
"@metamask/utils": "^11.4.2",
"uuid": "^9.0.0"
},
"devDependencies": {
Expand All @@ -55,7 +55,7 @@
"@metamask/eslint-config-jest": "^12.1.0",
"@metamask/eslint-config-nodejs": "^12.1.0",
"@metamask/eslint-config-typescript": "^12.1.0",
"@metamask/snaps-cli": "^6.7.0",
"@metamask/snaps-cli": "^8.1.0",
"@types/node": "^20.6.2",
"@typescript-eslint/eslint-plugin": "^5.33.0",
"@typescript-eslint/parser": "^5.33.0",
Expand All @@ -68,7 +68,7 @@
"eslint-plugin-n": "^16.1.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-promise": "^6.1.1",
"prettier": "^2.2.1",
"prettier": "^3.5.3",
Copy link

@cursor cursor bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incompatible Prettier and eslint-plugin-prettier versions

The snap package updated prettier to ^3.5.3 but kept eslint-plugin-prettier at ^4.2.1. Prettier 3.x introduced breaking API changes that require eslint-plugin-prettier version 5.x or higher. This mismatch will cause runtime errors when ESLint attempts to run Prettier, such as prettier.resolveConfig.sync is not a function.

Fix in Cursor Fix in Web

"rimraf": "^3.0.2",
"typescript": "^4.7.4"
},
Expand Down
1 change: 0 additions & 1 deletion packages/snap/snap.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { SnapConfig } from '@metamask/snaps-cli';

const config: SnapConfig = {
bundler: 'webpack',
input: 'src/index.ts',
server: { port: 8080 },
polyfills: {
Expand Down
8 changes: 6 additions & 2 deletions packages/snap/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,18 @@
},
"initialPermissions": {
"endowment:keyring": {
"allowedOrigins": ["https://metamask.github.io", "metamask.github.io"]
"allowedOrigins": [
"https://metamask.github.io",
"metamask.github.io",
"http://localhost:8000"
]
},
"endowment:rpc": {
"dapps": true
},
"snap_manageAccounts": {},
"snap_manageState": {}
},
"platformVersion": "6.19.0",
"platformVersion": "9.3.0",
"manifestVersion": "0.1"
}
Loading
Loading