Move permission schema metadata into 7715 permission types#267
Open
mj-kiwi wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 49ce0fa. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Description
Moves shared ERC-7715 permission schema metadata into
@metamask/7715-permission-types.🔄 What Changed?
List the specific changes made:
@metamask/7715-permission-types🚀 Why?
Explain the motivation behind these changes:
🧪 How to Test?
Describe how to test these changes:
yarn workspace @metamask/7715-permission-types testyarn workspace @metamask/7715-permission-types buildyarn workspace @metamask/7715-permission-types lintList any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes #
Related to #
📚 Additional Notes
Rendering remains in MetaMask Extension; this PR only moves shared schema metadata and pure helpers.
Note
Low Risk
Additive package API and declarative metadata only; no runtime permission enforcement changes, with tests for schema lookup edge cases.
Overview
Adds a new
permissions/schemamodule to@metamask/7715-permission-typesso MetaMask Extension (and other consumers) can share declarative metadata for Gator permission confirmation/review UI instead of duplicating it locally.The module defines schema types (
PermissionRenderContext, field elements, sections), a registry for supported types (native/ERC20 periodic, stream, allowance, token-approval-revocation), andgetPermissionSchemaEntrywith an unknown-type fallback and optional strict mode. Schemas describe which fields appear inconfirmation,reviewDetail, andreviewSummary, including redeemer/payee display logic that treats known MetaMask facilitator addresses specially.Also ships pure helpers: time/
MAX_UINT256constants, hex amount parsing, period/frequency i18n keys, stream rate conversions, andisMetaMaskFacilitatorAddress/areOnlyMetaMaskFacilitatorAddresses. The API is re-exported from the package root andpermissionsindex; changelog and unit tests cover lookup,__proto__safety, and facilitator matching.Reviewed by Cursor Bugbot for commit 668318e. Bugbot is set up for automated code reviews on this repo. Configure here.