Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/kernel-store/src/sqlite/nodejs.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,14 @@ describe('makeSQLKernelDatabase', () => {
recursive: true,
});
});

it('returns absolute path as-is and ensures parent directory exists', async () => {
const result = await getDBFilename('/home/user/.ocap/store.db');
expect(result).toBe('/home/user/.ocap/store.db');
expect(mockMkdir).toHaveBeenCalledWith('/home/user/.ocap', {
recursive: true,
});
});
});

describe('savepoint functionality', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/kernel-store/src/sqlite/nodejs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { Database as SqliteDatabase } from 'better-sqlite3';
import Sqlite from 'better-sqlite3';
import { mkdir } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { dirname, isAbsolute, join } from 'node:path';

import {
SQL_QUERIES,
Expand Down Expand Up @@ -334,6 +334,10 @@ export async function getDBFilename(label: string): Promise<string> {
if (label.startsWith(':')) {
return label;
}
if (isAbsolute(label)) {
await mkdir(dirname(label), { recursive: true });
return label;
}
const dbRoot = join(tmpdir(), './ocap-sqlite', getDBFolder());
await mkdir(dbRoot, { recursive: true });
return join(dbRoot, label);
Expand Down
Loading