generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add system subclusters and kernel facet service #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rekmarks
wants to merge
47
commits into
main
Choose a base branch
from
rekm/system-vats-redux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
2d20e96
feat(ocap-kernel): Add KernelFacet
rekmarks 7c314b3
feat(omnium-gatherum): Add system vats support
rekmarks 10cc18e
refactor(omnium-gatherum): Convert bootstrap-vat to TypeScript
rekmarks 0f20610
feat(kernel-browser-runtime): Add reset method to KernelFacade
rekmarks 2e9f67b
refactor(omnium-gatherum): Rename bootstrap-vat to controller-vat
rekmarks 8e086d0
fix(ocap-kernel): Avoid deadlock in E(kernelFacet) calls from within …
rekmarks 54e9e99
feat(ocap-kernel): Add globals config for vat compartment endowments
rekmarks 7a9c06c
feat(omnium-gatherum): Add callCapletMethod API and simplify echo caplet
rekmarks 161d5de
chore(omnium-gatherum): Remove dead code from controller migration
rekmarks 3ead152
fix(omnium-gatherum): Fix callBootstrap type annotations
rekmarks 35737d9
fix(omnium-gatherum): Address review feedback
rekmarks f431659
fix(omnium-gatherum): Add console forwarding from kernel-worker and vats
rekmarks 2f3d086
refactor(omnium): Rename bootstrap vat to controller vat
rekmarks 4feef90
test(ocap-kernel): Tweak kernel facet tests
rekmarks 23be8f7
fix(ocap-kernel,omnium-gatherum): Address PR review feedback
rekmarks 63eaac4
test(nodejs): Add system vat e2e tests
rekmarks a5b98da
refactor(ocap-kernel): Rename system vats to system subclusters and a…
rekmarks 0219613
refactor(ocap-kernel): Clean up orphaned system subclusters on kernel…
rekmarks b351ff9
refactor(nodejs): Convert system-vat test to TypeScript
rekmarks 2152f04
fix(ocap-kernel): Throw on corrupted system subcluster state
rekmarks 0f91b91
fix(omnium-gatherum): Restore controller vat from baggage on kernel r…
rekmarks ada3ebb
chore(cli): Add TODO for process.env.NODE_ENV injection
rekmarks 4b3db2c
test(nodejs): Fix type errors in system-vat.ts
rekmarks 4627815
fix(ocap-kernel,omnium-gatherum): Address PR review feedback
rekmarks 15dcf8c
fix(nodejs): Increase connection rate limit in queue management test
rekmarks 6672eb8
refactor: Consolidate KernelFacade into KernelFacet
rekmarks 3b5d23e
refactor(ocap-kernel): Replace getVatRoot with getPresence on Kernel
rekmarks f660f31
refactor(ocap-kernel): Simplify makeKernelFacet to spread deps
rekmarks d37faa0
test(nodejs): Fix broken e2e test
rekmarks 5b5b90f
refactor(ocap-kernel): Change Subcluster.vats from VatId[] to Record<…
rekmarks 4f0810b
fix(kernel-browser-runtime): Wrap mock methods to survive harden() in…
rekmarks 40f0b33
refactor(omnium): Add SystemSubclusterConfig type constraint
rekmarks 7a8551e
fix(ocap-kernel): Update system subcluster mappings on reload
rekmarks 59ba8f2
refactor(ocap-kernel): Move system subcluster lifecycle from Kernel t…
rekmarks ba08a8f
fix(extension): Update hardcoded ko IDs in e2e tests for kernelFacet …
rekmarks 3af3e2e
fix(ocap-kernel): Update system subcluster mappings in reloadAllSubcl…
rekmarks 9ce5379
refactor(omnium): Use proper Baggage type and simplify adapter
rekmarks a637417
refactor(omnium): Make logger non-optional in controllers
rekmarks 8002ee5
refactor(ocap-kernel): Simplify makeKernelFacet to bind methods inter…
rekmarks a9ab2c2
refactor(nodejs): Use options bag for makeTestKernel
rekmarks 7935dd7
chore: Extend vitest eslint rules to all test files
rekmarks 6f7cff4
fix(omnium): Fix omnium.caplet global type declarations
rekmarks 8691db8
test(nodejs): Clean up system sybcluster e2e tests
rekmarks 87604ff
fix(ocap-kernel): Use hasProperty to check allowed globals
rekmarks cc6ceec
test(omnium): Add non-trivial e2e test
rekmarks 9441379
fix(omnium): Reject capletFacetP on resuscitation failure
rekmarks 31868d8
fix(ocap-kernel): Call provideFacet() unconditionally in Kernel#init
rekmarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 23 additions & 1 deletion
24
packages/kernel-browser-runtime/src/kernel-worker/captp/kernel-captp.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to address in a follow-up. Requires changes to how we bundle vats with Vite best not added to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#812