fix: add Update Amount Data outer prefix to money account deposit amount callback

[matthewwalsh0]

Summary

Adds a two-level error prefix to the money account deposit amount-update callback in useUpdateTransactionPayAmount:

• Outer (updateTransactionPayAmount deposit block): Update Amount Data:
• Inner (applyMoneyAccountAmountUpdates / syncMoneyAccountDepositRequiredAssets): Money Account Deposit: (pre-existing)

A failure during amount data update now surfaces as:

Update Amount Data: Money Account Deposit: <original error>

This mirrors the naming convention introduced on the core side (MetaMask/core#9250) and makes it immediately clear from the error message that the failure occurred in the deposit amount-update step.

Changes

• useUpdateTransactionPayAmount.ts: Add UPDATE_AMOUNT_DATA_ERROR_PREFIX constant; wrap the moneyAccountDeposit branch in a try-catch that applies the outer prefix
• useUpdateTransactionPayAmount.test.ts: Update three error-propagation assertions to assert the full prefix-chained message

[mm-token-exchange-service]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• PR body does not match pull-request-template.md (one or more section headings are missing). See https://github.com/MetaMask/metamask-mobile/blob/main/.github/scripts/shared/pr-template-checks.ts#L15-L23.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeMoney, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR modifies useUpdateTransactionPayAmount.ts to wrap the moneyAccountDeposit transaction handling in a try/catch block, prefixing errors with 'Update Amount Data: '. The test file updates assertions to match the new error message format.

This is a low-risk error handling improvement that:

1. Affects the Money Account Deposit flow → SmokeMoney (MetaMask Card/fiat deposit flows)
2. Lives in the confirmations/hooks/pay directory and affects transaction confirmation behavior → SmokeConfirmations

Per tag descriptions: SmokeMoney covers card Add Funds (Deposit/Swap paths), and when selecting SmokeMoney for flows that execute transactions, SmokeConfirmations should also be selected.

No performance impact expected — this is purely an error handling change with no effect on rendering, data fetching, or app startup.

Performance Test Selection:
The change is purely an error handling improvement (adding try/catch with error prefix) in the Money Account Deposit hook. There is no impact on rendering performance, data fetching, app launch, or any other performance-sensitive flow.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud