Skip to content

chore(runway): cherry-pick fix: cp-8.0.0 require EIP-7702 for sponsored gas transactions#32307

Merged
sleepytanya merged 1 commit into
release/8.0.0from
runway-cherry-pick-8.0.0-1782296401
Jun 24, 2026
Merged

chore(runway): cherry-pick fix: cp-8.0.0 require EIP-7702 for sponsored gas transactions#32307
sleepytanya merged 1 commit into
release/8.0.0from
runway-cherry-pick-8.0.0-1782296401

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Sponsored and gas-included transaction publishing depends on the
EIP-7702 delegation relay path. Previously, when atomic EIP-7702 support
was unavailable for the selected chain, the delegation publish hook
returned an empty result, which allowed the publish pipeline to continue
to later publication paths.

This PR makes that path fail closed for sponsored and gas-included
transactions by throwing a clear error when the chain does not support
EIP-7702 atomic batching. Non-sponsored transactions keep the existing
empty-result behavior when EIP-7702 is unavailable.

Changelog

CHANGELOG entry: Fixed sponsored and gas-included transactions falling
back when EIP-7702 support is unavailable

Related issues

Refs: MetaMask/core#9240

Manual testing steps

N/A - covered by unit tests for the transaction publish hook.

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes transaction publish behavior for gas-sponsored and
gas-included flows on chains without EIP-7702, blocking unsafe fallbacks
instead of silently continuing.

Overview
Sponsored and gas-included publishes must use the EIP-7702
delegation relay. When atomic batch support is missing for the chain,
Delegation7702PublishHook used to return an empty result so later
publish hooks could run.

This change throws for isGasFeeSponsored or isGasFeeIncluded
when the chain is not EIP-7702-capable, with a clear error (prefixed as
Gas Station 7702:). Regular transactions still get the empty result
and can fall through.

Gas flags are normalized earlier (Boolean on isGasFeeIncluded /
isGasFeeSponsored) and includeTransfer now keys off the same
isSponsored flag. Unit tests cover sponsored and gas-included cases
when atomic batch is unsupported.

Reviewed by Cursor Bugbot for commit
4e5dfa7. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[48adf87](https://github.com/MetaMask/metamask-mobile/commit/48adf87a68825ffbc76be9f2db2c8e4afec9708a)

…ed gas transactions (#32253)

## **Description**

Sponsored and gas-included transaction publishing depends on the
EIP-7702 delegation relay path. Previously, when atomic EIP-7702 support
was unavailable for the selected chain, the delegation publish hook
returned an empty result, which allowed the publish pipeline to continue
to later publication paths.

This PR makes that path fail closed for sponsored and gas-included
transactions by throwing a clear error when the chain does not support
EIP-7702 atomic batching. Non-sponsored transactions keep the existing
empty-result behavior when EIP-7702 is unavailable.

## **Changelog**

CHANGELOG entry: Fixed sponsored and gas-included transactions falling
back when EIP-7702 support is unavailable

## **Related issues**

Refs: MetaMask/core#9240

## **Manual testing steps**

N/A - covered by unit tests for the transaction publish hook.

## **Screenshots/Recordings**

N/A

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes transaction publish behavior for gas-sponsored and
gas-included flows on chains without EIP-7702, blocking unsafe fallbacks
instead of silently continuing.
> 
> **Overview**
> **Sponsored** and **gas-included** publishes must use the EIP-7702
delegation relay. When atomic batch support is missing for the chain,
`Delegation7702PublishHook` used to return an empty result so later
publish hooks could run.
> 
> This change **throws** for `isGasFeeSponsored` or `isGasFeeIncluded`
when the chain is not EIP-7702-capable, with a clear error (prefixed as
`Gas Station 7702:`). Regular transactions still get the empty result
and can fall through.
> 
> Gas flags are normalized earlier (`Boolean` on `isGasFeeIncluded` /
`isGasFeeSponsored`) and `includeTransfer` now keys off the same
`isSponsored` flag. Unit tests cover sponsored and gas-included cases
when atomic batch is unsupported.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
4e5dfa7. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner June 24, 2026 10:20
@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions Bot added size-S risk:low AI analysis: low risk labels Jun 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

@sleepytanya sleepytanya enabled auto-merge (squash) June 24, 2026 16:30
@sleepytanya sleepytanya merged commit 2b64466 into release/8.0.0 Jun 24, 2026
117 checks passed
@sleepytanya sleepytanya deleted the runway-cherry-pick-8.0.0-1782296401 branch June 24, 2026 16:30
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk:low AI analysis: low risk size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants