Skip to content

fix(ci): standardize Appium Playwright JSON report filename#31756

Merged
cmd-ob merged 1 commit into
mainfrom
e2e/fix-pw-report-name
Jun 15, 2026
Merged

fix(ci): standardize Appium Playwright JSON report filename#31756
cmd-ob merged 1 commit into
mainfrom
e2e/fix-pw-report-name

Conversation

@cmd-ob

@cmd-ob cmd-ob commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description

Standardize the Playwright JSON file inside each Appium CI artifact to playwright-report.json, matching the default results-file-pattern in the upcoming playwright-test-health-report github-tools action (MetaMask/github-tools#262).

Suite/shard identity stays in the artifact name (playwright-json-report-{test-suite-name}); only the inner zip filename is fixed. New Appium smoke tags can be added without changing the daily report workflow config.

Changelog

CHANGELOG entry: null

Related issues

Refs: Follow-up to Appium JSON artifact upload — prepares for github-tools playwright-test-health-report (MetaMask/github-tools#262).

Manual testing steps

N/A — CI-only change. Post-merge verification on main:

  • Confirm Appium jobs still upload playwright-json-report-* artifacts.
  • Open an artifact zip and verify the JSON file is named playwright-report.json (not {suite-name}.json).

Screenshots/Recordings

Before

N/A — CI workflow change only.

After

N/A — CI workflow change only.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

@cmd-ob cmd-ob requested a review from a team as a code owner June 15, 2026 19:49
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jun 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR contains exactly 2 changed files:

  1. .github/workflows/run-appium-e2e-workflow.yml: Changes the PLAYWRIGHT_JSON_OUTPUT_FILE environment variable from a dynamic path tests/test-reports/playwright-json/${{ inputs.test-suite-name }}.json to a fixed filename tests/test-reports/playwright-json/playwright-report.json. The suite identity is preserved in the artifact name prefix (playwright-json-report-*). This is a pure CI infrastructure fix for the GitHub tools playwright-test-health-report integration — it only affects how the JSON report file is named/uploaded, not what tests run or how they execute.

  2. tests/playwright.smoke-appium.config.ts: Updates a single comment line to reflect the new fixed filename behavior. This is a comment-only change with zero functional impact.

Neither change affects:

  • Any app source code
  • Any E2E test logic, selectors, page objects, or flows
  • Any test execution behavior
  • Any performance-sensitive code paths

This is a pure CI reporting infrastructure fix. No E2E test tags need to be run to validate this change, as it only affects artifact upload paths in the CI workflow.

Performance Test Selection:
No app code changes were made. The PR only modifies CI workflow artifact upload paths and a comment in the Playwright config. There is no impact on any performance-sensitive code paths, rendering, or user flows.

View GitHub Actions results

@cmd-ob cmd-ob enabled auto-merge June 15, 2026 19:59
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.28%. Comparing base (9cc924c) to head (165d1a2).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #31756   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files        5750     5755    +5     
  Lines      149002   149088   +86     
  Branches    34819    34854   +35     
=======================================
+ Hits       124092   124170   +78     
- Misses      16553    16556    +3     
- Partials     8357     8362    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmd-ob cmd-ob added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit d2f1df5 Jun 15, 2026
119 of 121 checks passed
@cmd-ob cmd-ob deleted the e2e/fix-pw-report-name branch June 15, 2026 21:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.83.0 Issue or pull request that will be included in release 7.83.0 label Jun 15, 2026
@tommasini tommasini added release-8.0.0 Issue or pull request that will be included in release 8.0.0 and removed release-7.83.0 Issue or pull request that will be included in release 7.83.0 labels Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.0.0 Issue or pull request that will be included in release 8.0.0 risk:low AI analysis: low risk size-S team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants