feat: instant transaction support with confirmation render optimizations#27783
Draft
matthewwalsh0 wants to merge 3 commits intomainfrom
Draft
feat: instant transaction support with confirmation render optimizations#27783matthewwalsh0 wants to merge 3 commits intomainfrom
matthewwalsh0 wants to merge 3 commits intomainfrom
Conversation
Reduce perceived latency for transaction confirmations by guarding expensive hooks behind skip/enabled flags, adding BigNumber useMemo caching, bypassing Redux for instant approval lookups, and wiring addTransactionBatchInstant through developer options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize the confirmation render path for instant transactions. Navigate to the confirmation screen before controller work completes, cache token icon state to prevent flicker during data hydration, and reduce unnecessary re-renders across the confirmation flow.
Depends on core PR for
startTransactionsupport: MetaMask/core#8248Changelog
CHANGELOG entry: Improved confirmation screen load performance for transactions
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist