Skip to content

chore(INFRA-3041): Stable Sync workflow update github-tools#22197

Merged
XxdpavelxX merged 2 commits into
mainfrom
INFRA-3041-StableBranchSync
Nov 7, 2025
Merged

chore(INFRA-3041): Stable Sync workflow update github-tools#22197
XxdpavelxX merged 2 commits into
mainfrom
INFRA-3041-StableBranchSync

Conversation

@XxdpavelxX

@XxdpavelxX XxdpavelxX commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Description

Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-3041
Github-tools PR: MetaMask/github-tools#154, MetaMask/github-tools#160

Changelog PR before updates: consensys-test#31
Changelog PR after updates: consensys-test#37

Summary of Changes

Prevented github-tools from appearing in PRs
File: github-tools/.github/workflows/stable-sync.yml
What: Added explicit cleanup commands to unstage and remove github-tools directory before pushing
Impact: The sync PR will no longer include a github-tools/ submodule or directory
Disabled package.json version bump for Extension
File: github-tools/.github/scripts/stable-sync.js
What: Removed the yarn version logic that bumped package.json version
Before: Extension ran yarn version to update the version
After: Extension now preserves package.json from stable branch (same as mobile)
Impact: No version bump will occur in the sync PR for either mobile or extension
Verified PR title format
File: github-tools/.github/workflows/stable-sync.yml (line 147)
What: Confirmed it already uses release: prefix (no change needed)
Format: "release: sync stable to main for version X.Y.Z"
Testing in Extension: consensys-test/metamask-extension-test-workflow2#209, https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/18951817173
Testing in Mobile: consensys-test#30, https://github.com/consensys-test/metamask-mobile-test-workflow/actions/runs/18951842114

Testing Post CR comments: consensys-test/metamask-extension-test-workflow2#212

Changelog

CHANGELOG entry: None

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates the stable branch sync workflow to use metamask/github-tools commit 701a894 for both the reusable workflow and the input version.

  • CI/Workflows:
    • Update uses in .github/workflows/stable-branch-sync.yml to metamask/github-tools/.github/workflows/stable-sync.yml@701a894f38883ab48560f948e98b76cc6b4d623f.
    • Set github-tools-version input to 701a894f38883ab48560f948e98b76cc6b4d623f.

Written by Cursor Bugbot for commit 77f5118. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Nov 5, 2025
@XxdpavelxX XxdpavelxX requested a review from sethkfman November 5, 2025 15:56
@XxdpavelxX XxdpavelxX self-assigned this Nov 5, 2025
@sethkfman sethkfman changed the title INFRA-3041:Stable Sync workflow update github-tools chore(INFRA-3041): Stable Sync workflow update github-tools Nov 5, 2025
@XxdpavelxX XxdpavelxX enabled auto-merge November 6, 2025 18:34
@XxdpavelxX XxdpavelxX force-pushed the INFRA-3041-StableBranchSync branch from e348940 to 77f5118 Compare November 7, 2025 17:54
@sonarqubecloud

sonarqubecloud Bot commented Nov 7, 2025

Copy link
Copy Markdown

@XxdpavelxX XxdpavelxX added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit 1c5f2ec Nov 7, 2025
55 checks passed
@XxdpavelxX XxdpavelxX deleted the INFRA-3041-StableBranchSync branch November 7, 2025 18:35
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 7, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-XS team-dev-ops DevOps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants