Skip to content

ci: update all actions to Node 24#41902

Merged
HowardBraham merged 1 commit into
mainfrom
node-24
Apr 20, 2026
Merged

ci: update all actions to Node 24#41902
HowardBraham merged 1 commit into
mainfrom
node-24

Conversation

@HowardBraham

@HowardBraham HowardBraham commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Description

The bulk of the work was done in MetaMask/github-tools#234

This just finishes it off with

  • SonarSource update
  • change @main to @v1
  • change v1.2.0 to @v1

Changelog

CHANGELOG entry: null


Note

Low Risk
Low risk workflow-only changes that update action references; main risk is CI behavior changes if the new action versions differ or introduce incompatibilities.

Overview
Updates GitHub Actions workflow dependencies to stable version tags.

Switches the feature-flag drift Slack notification action from @main to @v1, changes release branch automation actions from @v1.2.0 to @v1, and bumps the pinned SonarCloud scan action from v7.0.0 to v7.1.0 (new commit SHA).

Reviewed by Cursor Bugbot for commit 5b56407. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Apr 17, 2026
@HowardBraham HowardBraham changed the title ci: update all actions to Node 24 [skip-e2e] ci: update all actions to Node 24 Apr 17, 2026
@metamaskbotv2

metamaskbotv2 Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b0f213f]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24581244294 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-browserify
loadNewAccount🟡 [Show logs]
confirmTx🟡 [Show logs]
bridgeUserActions🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -78%
  • loadNewAccount/total: -78%
  • bridgeUserActions/bridge_load_page: -18%
  • bridgeUserActions/bridge_load_asset_picker: -60%
  • bridgeUserActions/bridge_search_token: -20%
  • bridgeUserActions/total: -18%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
Startup Benchmarks · Samples: 100
Benchmarkchrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
startupStandardHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -25%
  • startupStandardHome/load: -14%
  • startupStandardHome/domContentLoaded: -16%
  • startupStandardHome/domInteractive: +12%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -19%
  • startupStandardHome/numNetworkReqs: -37%
  • startupStandardHome/uiStartup: -22%
  • startupStandardHome/load: -17%
  • startupStandardHome/domContentLoaded: -16%
  • startupStandardHome/backgroundConnect: -37%
  • startupStandardHome/firstReactRender: -23%
  • startupStandardHome/loadScripts: -17%
  • startupStandardHome/setupStore: -13%
  • startupStandardHome/numNetworkReqs: -44%
  • startupStandardHome/backgroundConnect: +20%
  • startupStandardHome/initialActions: +33%
  • startupStandardHome/numNetworkReqs: -29%
  • startupStandardHome/uiStartup: -17%
  • startupStandardHome/domInteractive: -59%
  • startupStandardHome/initialActions: -43%
  • startupStandardHome/setupStore: -47%
  • startupStandardHome/numNetworkReqs: -32%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-browserify
onboardingImportWallet🟢 [Show logs]
onboardingNewWallet🟢 [Show logs]
assetDetails🟡 [Show logs]
solanaAssetDetails🟡 [Show logs]
importSrpHome🟡 [Show logs]
sendTransactions🟡 [Show logs]
swap🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -84%
  • onboardingImportWallet/metricsToWalletReadyScreen: -31%
  • onboardingImportWallet/doneButtonToHomeScreen: -77%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: +36%
  • onboardingImportWallet/total: -42%
  • onboardingNewWallet/srpButtonToPwForm: -78%
  • onboardingNewWallet/skipBackupToMetricsScreen: -68%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -23%
  • onboardingNewWallet/doneButtonToAssetList: -22%
  • onboardingNewWallet/total: -24%
  • assetDetails/assetClickToPriceChart: -71%
  • assetDetails/total: -71%
  • solanaAssetDetails/assetClickToPriceChart: -58%
  • solanaAssetDetails/total: -58%
  • importSrpHome/loginToHomeScreen: -13%
  • importSrpHome/openAccountMenuAfterLogin: -55%
  • importSrpHome/homeAfterImportWithNewWallet: -68%
  • importSrpHome/total: -62%
  • sendTransactions/openSendPageFromHome: -12%
  • sendTransactions/reviewTransactionToConfirmationPage: +37%
  • sendTransactions/total: +34%
  • swap/openSwapPageFromHome: -96%
  • swap/fetchAndDisplaySwapQuotes: +32%
  • swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 2.5s
  • 🟡 solanaAssetDetails/FCP: p75 2.5s
  • 🟡 importSrpHome/FCP: p75 2.4s
  • 🟡 sendTransactions/FCP: p75 2.5s
  • 🟡 swap/FCP: p75 2.5s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-browserify
dappPageLoad🟢 [Show logs]
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 2.05 KiB (0.03%)
  • ui: 1.48 KiB (0.02%)
  • common: -261.94 KiB (-1.95%)

@metamaskbotv2

metamaskbotv2 Bot commented Apr 19, 2026

Copy link
Copy Markdown
Contributor
Builds ready [5b56407] [reused from 4ede4f5]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): 71bd826 | Date: 10/14/58243 | Pipeline: 24637820656 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-browserify
loadNewAccount🟡 [Show logs]
confirmTx🟡 [Show logs]
bridgeUserActions🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -22%
  • loadNewAccount/total: -22%
  • bridgeUserActions/bridge_load_asset_picker: -48%
  • bridgeUserActions/total: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.7s
  • 🟡 confirmTx/FCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
startupStandardHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -25%
  • startupStandardHome/load: -15%
  • startupStandardHome/domContentLoaded: -16%
  • startupStandardHome/firstReactRender: -14%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -20%
  • startupStandardHome/numNetworkReqs: -37%
  • startupStandardHome/domInteractive: +18%
  • startupStandardHome/firstPaint: +37%
  • startupStandardHome/backgroundConnect: -23%
  • startupStandardHome/firstReactRender: -19%
  • startupStandardHome/numNetworkReqs: -44%
  • startupStandardHome/uiStartup: -14%
  • startupStandardHome/domInteractive: -59%
  • startupStandardHome/backgroundConnect: +11%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/numNetworkReqs: -34%
  • startupStandardHome/uiStartup: -15%
  • startupStandardHome/domInteractive: -43%
  • startupStandardHome/initialActions: +14%
  • startupStandardHome/setupStore: -60%
  • startupStandardHome/numNetworkReqs: -32%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-browserify
onboardingImportWallet🟢 [Show logs]
onboardingNewWallet🟡 [Show logs]
assetDetails🟡 [Show logs]
solanaAssetDetails🟡 [Show logs]
importSrpHome🟡 [Show logs] · 🟡 cls
sendTransactions🟢 [Show logs]
swap🟡 [Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: -88%
  • onboardingImportWallet/confirmSrpToPwForm: -28%
  • onboardingImportWallet/pwFormToMetricsScreen: -25%
  • onboardingImportWallet/metricsToWalletReadyScreen: -51%
  • onboardingImportWallet/doneButtonToHomeScreen: -35%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/total: -47%
  • onboardingNewWallet/srpButtonToPwForm: -79%
  • onboardingNewWallet/skipBackupToMetricsScreen: -67%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: -21%
  • onboardingNewWallet/total: -11%
  • assetDetails/assetClickToPriceChart: -77%
  • assetDetails/total: -77%
  • solanaAssetDetails/assetClickToPriceChart: -71%
  • solanaAssetDetails/total: -71%
  • importSrpHome/loginToHomeScreen: -25%
  • importSrpHome/openAccountMenuAfterLogin: -60%
  • importSrpHome/homeAfterImportWithNewWallet: +48%
  • importSrpHome/total: +39%
  • swap/openSwapPageFromHome: -96%
  • swap/fetchAndDisplaySwapQuotes: -68%
  • swap/total: -72%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 onboardingNewWallet/FCP: p75 2.0s
  • 🟡 assetDetails/INP: p75 264ms
  • 🟡 assetDetails/FCP: p75 2.4s
  • 🟡 assetDetails/LCP: p75 2.5s
  • 🟡 solanaAssetDetails/FCP: p75 2.5s
  • 🟡 importSrpHome/INP: p75 272ms
  • 🟡 importSrpHome/FCP: p75 2.5s
  • 🟡 importSrpHome/CLS: p75 0.151
  • 🟡 swap/FCP: p75 2.7s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-browserify
dappPageLoad🟢 [Show logs]
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@sonarqubecloud

Copy link
Copy Markdown

@HowardBraham HowardBraham enabled auto-merge April 20, 2026 06:51
@HowardBraham HowardBraham added this pull request to the merge queue Apr 20, 2026
@HowardBraham HowardBraham added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Apr 20, 2026
Merged via the queue into main with commit 141edbd Apr 20, 2026
75 checks passed
@HowardBraham HowardBraham deleted the node-24 branch April 20, 2026 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
@github-actions github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Apr 20, 2026
@metamaskbot metamaskbot added the release-13.29.0 Issue or pull request that will be included in release 13.29.0 label Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.29.0 Issue or pull request that will be included in release 13.29.0 size-XS skip-release-validation team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants