release: fix three issues#40079
Merged
Merged
Conversation
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
commented
Feb 13, 2026
HowardBraham
left a comment
HowardBraham
left a comment
Contributor
Author
There was a problem hiding this comment.
Explanations of each change
| - main | ||
| - stable | ||
| - release/* | ||
| - '!release/*-Changelog' |
Contributor
Author
There was a problem hiding this comment.
On a changelog branch, like release/13.19.0-Changelog, the workflow ran twice, on both push and pull_request
Member
There was a problem hiding this comment.
Branch names release/* are intended to be reserved for actual releases. We haven't actually been enforcing this, but there was a ruleset intended to start enforcing this soon (which we wanted to do in order to lock down some secrets used by release branches).
Given that, perhaps a better fix for this problem would be to fix the branch name used by the automated changelog generation workflow.
Contributor
Author
There was a problem hiding this comment.
Ah, that's over in github-tools
Comment on lines
8
to
+31
| @@ -25,9 +22,13 @@ jobs: | |||
| use-yarn-hydrate: true | |||
|
|
|||
| - name: Get changed files with git diff | |||
| # On branch `stable`, there's no reason to do a diff | |||
| if: ${{ (github.head_ref || github.ref_name) != 'stable' }} | |||
| run: yarn tsx .github/scripts/git-diff-default-branch.ts | |||
|
|
|||
| - name: Upload changed files artifact | |||
| # On branch `stable`, there's no reason to do a diff | |||
| if: ${{ (github.head_ref || github.ref_name) != 'stable' }} | |||
Contributor
Author
There was a problem hiding this comment.
prep-e2e had the gate if: ${{ (github.head_ref || github.ref_name) != 'stable' }} on the whole job, which prevented it from generating test-runs-for-splitting. Changed to gating just the diff steps.
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
HowardBraham
had a problem deploying
to
pr-comment
GitHub Actions
Failure
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
HowardBraham
commented
Feb 13, 2026
|
|
||
| - name: Download page load benchmark results | ||
| if: ${{ github.event_name == 'pull_request' }} | ||
| continue-on-error: true |
Contributor
Author
There was a problem hiding this comment.
If needs-benchmarks == 'false' this would fail
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [994bbb5]
UI Startup Metrics (1449 ± 115 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
HowardBraham
commented
Feb 13, 2026
Comment on lines
+568
to
570
| }} | ||
| needs: | ||
| - get-requirements |
Contributor
Author
There was a problem hiding this comment.
The release branch was not running job publish-prerelease because needs-benchmarks == 'false' and the benchmarks were prereqs
Gudahtt
reviewed
Feb 13, 2026
| contains(fromJson('["success","skipped"]'), needs.build-test-mv2-browserify.result) && | ||
| contains(fromJson('["success","skipped"]'), needs.build-test-flask-browserify.result) && | ||
| contains(fromJson('["success","skipped"]'), needs.build-test-flask-mv2-browserify.result) && | ||
| contains(fromJson('["success","skipped","failure"]'), needs.run-benchmarks.result) && |
Member
There was a problem hiding this comment.
Nit: Since this is all possible statuses, we could omit these from the comparison
Contributor
Author
There was a problem hiding this comment.
Yeah, the only missing status was cancelled, but that was already covered by !cancelled(), so I took it out.
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [93b4b7b]
UI Startup Metrics (1381 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
| push: | ||
| branches: | ||
| - 'release/*' | ||
| - 'release/[0-9]+.[0-9]+.[0-9]+' |
There was a problem hiding this comment.
Release changelog trigger pattern broken
High Severity
The new branch filter uses release/[0-9]+.[0-9]+.[0-9]+, but GitHub branch filters are glob patterns, so + is treated literally instead of as a regex quantifier. This prevents release/x.y.z branches from matching, so .github/workflows/update-release-changelog.yml no longer triggers for normal release branches.
Contributor
Author
There was a problem hiding this comment.
Not according to the documentation at https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet
HowardBraham
temporarily deployed
to
pr-comment
GitHub Actions
Inactive
Contributor
Builds ready [95b4e36]
UI Startup Metrics (1439 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
metamaskbot
added
the
release-13.20.0
metamaskbot
added
release-13.19.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three issues we just discovered during the most recent release cycle:
release/13.19.0-Changelog, the workflow ran twice, on bothpushandpull_request.github/workflows/update-release-changelog.ymlpublish-prereleasebecauseneeds-benchmarks == 'false'and the benchmarks were prereqsprep-e2ehad the gateif: ${{ (github.head_ref || github.ref_name) != 'stable' }}on the whole job, which prevented it from generatingtest-runs-for-splitting. Changed to gating just the diff steps.Changelog
CHANGELOG entry: null
Note
Low Risk
Workflow-only changes to CI/release automation; main risk is accidentally skipping/triggering release jobs due to updated job conditions and branch filters.
Overview
Fixes release-cycle GitHub Actions behavior.
publish-prereleaseinmain.ymlis now explicitly gated to run when releases are enabled and not cancelled, requiring all non-benchmark prerequisite jobs to besuccess/skippedso benchmarks no longer block prereleases.prep-e2e.ymlnow runs onstable, but skips the diff/artifact steps there so it still producestest-runs-for-splitting.publish-prerelease.ymlmakes downloadingpage-load-benchmark-resultsnon-blocking (continue-on-error).update-release-changelog.ymlis simplified by narrowing the push branch filter to semver-likerelease/x.y.zand removing the extra branch-validation job.Written by Cursor Bugbot for commit 95b4e36. This will update automatically on new commits. Configure here.