chore: INFRA-3180:Fix create pr workflow commit.csv issue by XxdpavelxX · Pull Request #38526 · MetaMask/metamask-extension

XxdpavelxX · 2025-12-03T15:28:38Z

Description

Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-3180
Create-release-pr workflow currently uses teams.json file which was deprecated instead of new topology.json to generate commits.csv. Causes issues with commits.csv. Fixed in this Pr

Discussed here: https://consensys.slack.com/archives/C09B64PEHAQ/p1764576026224679

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Update workflow to use MetaMask/github-tools create-release-pr action v1.1.2 instead of v1.1.0.

^{Written by Cursor Bugbot for commit bff89c8. This will update automatically on new commits. Configure here.}

github-actions · 2025-12-03T15:28:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gauthierpetetin · 2025-12-03T15:36:28Z

    steps:
      - name: Create Release PR
-        uses: MetaMask/github-tools/.github/actions/create-release-pr@v1.1.0
+        uses: MetaMask/github-tools/.github/actions/create-release-pr@265e8b3632a5b42a5d4f5c08e549c1f47aa9b898


@Qbandev I wonder what's the new process with regards to versioning. Shall we now always create a new github-tools release when updating github-tools?

Good catch, are we manually cutting a new release version whenever there's an update in github-tools?

gauthierpetetin · 2025-12-03T15:54:48Z

    steps:
      - name: Create Release PR
-        uses: MetaMask/github-tools/.github/actions/create-release-pr@v1.1.0
+        uses: MetaMask/github-tools/.github/actions/create-release-pr@v1.1.1


It seems we haven't added 1.1.1 to github-tools changelog. Here's an example PR for github-tools release: MetaMask/github-tools#176

metamaskbot · 2025-12-03T16:24:52Z

Builds ready [85a4e2d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1302 ± 119 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1302	1058	1627	119	1391	1485
			load	1085	879	1382	107	1150	1271
			domContentLoaded	1079	872	1376	106	1143	1264
			domInteractive	29	16	164	26	23	95
			firstPaint	523	97	1283	422	1043	1233
			backgroundConnect	230	204	269	15	242	259
			firstReactRender	33	20	171	17	37	55
			getState	37	17	122	19	44	75
			initialActions	1	0	7	1	1	3
			loadScripts	855	669	1164	102	926	1036
			setupStore	12	5	31	5	13	24
			numNetworkReqs	11	5	73	18	5	68
	Browserify	Power User Home	uiStartup	2012	1712	2748	245	2189	2518
			load	1013	878	1399	128	1044	1317
			domContentLoaded	1002	870	1386	127	1029	1304
			domInteractive	30	17	139	21	27	82
			firstPaint	515	83	1404	409	954	1277
			backgroundConnect	250	198	736	100	231	528
			firstReactRender	55	40	265	23	55	77
			getState	202	145	729	93	198	294
			initialActions	1	0	3	1	1	2
			loadScripts	792	669	1143	122	817	1085
			setupStore	16	9	46	8	16	38
			numNetworkReqs	81	63	234	30	76	152
	Webpack	Standard Home	uiStartup	807	701	983	69	833	956
			load	629	562	799	64	650	781
			domContentLoaded	624	558	793	64	645	774
			domInteractive	27	15	102	21	23	91
			firstPaint	213	79	780	145	209	636
			backgroundConnect	10	5	35	5	13	22
			firstReactRender	27	20	43	6	32	36
			getState	27	12	91	12	36	45
			initialActions	1	0	3	1	1	1
			loadScripts	621	555	785	62	642	765
			setupStore	11	5	32	4	12	17
			numNetworkReqs	11	5	73	17	5	62
	Webpack	Power User Home	uiStartup	1612	1239	2192	249	1854	2002
			load	671	583	1256	100	679	881
			domContentLoaded	662	577	1246	99	671	874
			domInteractive	31	17	109	23	28	102
			firstPaint	317	85	918	233	593	835
			backgroundConnect	152	8	653	234	504	572
			firstReactRender	58	45	86	8	63	72
			getState	175	140	351	27	183	223
			initialActions	1	0	2	1	1	2
			loadScripts	660	575	1237	98	669	870
			setupStore	17	7	46	9	16	41
			numNetworkReqs	77	31	252	30	74	141
Firefox	Browserify	Standard Home	uiStartup	1311	1081	1716	140	1373	1636
			load	1088	931	1417	104	1147	1383
			domContentLoaded	1088	931	1417	104	1145	1383
			domInteractive	62	27	200	34	85	134
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	22	161	32	45	140
			firstReactRender	22	18	39	4	23	36
			getState	11	6	86	9	10	23
			initialActions	1	0	3	0	1	2
			loadScripts	1062	917	1376	93	1116	1294
			setupStore	13	5	208	24	10	28
			numNetworkReqs	12	5	68	17	6	62
	Browserify	Power User Home	uiStartup	3072	1897	5079	943	4048	4807
			load	1389	926	2696	520	1463	2590
			domContentLoaded	1388	920	2696	520	1462	2590
			domInteractive	99	32	442	66	101	244
			firstPaint	-	-	-	-	-	-
			backgroundConnect	336	23	2030	429	429	1193
			firstReactRender	62	37	174	26	64	133
			getState	330	84	1384	294	466	989
			initialActions	2	1	3	1	2	3
			loadScripts	1199	909	2541	304	1302	2029
			setupStore	147	4	1201	235	111	770
			numNetworkReqs	87	51	215	41	76	201
	Webpack	Standard Home	uiStartup	1492	1221	2093	150	1591	1784
			load	1235	1070	1645	112	1300	1453
			domContentLoaded	1235	1070	1644	112	1300	1453
			domInteractive	59	27	168	35	81	141
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	20	168	31	46	115
			firstReactRender	27	19	46	5	30	38
			getState	14	7	89	13	13	47
			initialActions	1	0	3	1	2	2
			loadScripts	1204	1055	1511	98	1267	1393
			setupStore	14	6	176	21	11	42
			numNetworkReqs	12	5	70	17	7	62
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-

📊 Page Load Benchmark Results

Current Commit: 85a4e2d | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±114ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 728ms (±112ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±95ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	114ms	1.00s	2.15s	1.05s	2.15s
domContentLoaded	728ms	112ms	697ms	1.82s	739ms	1.82s
firstPaint	85ms	95ms	56ms	1.03s	88ms	1.03s
firstContentfulPaint	85ms	95ms	56ms	1.03s	88ms	1.03s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

metamaskbot · 2025-12-03T18:54:45Z

Builds ready [bff89c8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 119 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1214	1010	1562	119	1307	1405
			load	1012	829	1342	107	1076	1209
			domContentLoaded	1006	822	1332	106	1072	1193
			domInteractive	26	13	172	24	21	86
			firstPaint	630	117	1343	397	1013	1145
			backgroundConnect	207	177	253	15	215	233
			firstReactRender	26	18	61	7	28	43
			getState	34	14	122	19	38	86
			initialActions	1	0	2	1	1	2
			loadScripts	806	635	1110	100	867	985
			setupStore	10	6	26	3	11	16
			numNetworkReqs	11	5	69	18	5	64
	Browserify	Power User Home	uiStartup	2116	1724	2849	228	2225	2585
			load	1083	935	1685	136	1102	1355
			domContentLoaded	1072	924	1677	137	1092	1346
			domInteractive	35	19	207	28	31	107
			firstPaint	577	98	1382	411	1015	1329
			backgroundConnect	266	213	811	102	246	527
			firstReactRender	60	44	334	29	63	85
			getState	210	159	736	79	213	314
			initialActions	1	0	3	1	1	2
			loadScripts	847	715	1452	136	864	1124
			setupStore	18	11	42	8	18	38
			numNetworkReqs	78	64	161	21	74	137
	Webpack	Standard Home	uiStartup	837	709	1417	88	872	966
			load	649	573	1035	75	687	796
			domContentLoaded	645	568	1025	74	683	789
			domInteractive	26	15	157	23	22	95
			firstPaint	232	92	825	172	214	742
			backgroundConnect	12	5	70	11	13	31
			firstReactRender	27	20	56	6	31	40
			getState	28	13	97	14	34	54
			initialActions	1	0	4	1	1	1
			loadScripts	642	565	1016	73	681	783
			setupStore	11	6	37	4	12	18
			numNetworkReqs	10	5	71	16	5	59
	Webpack	Power User Home	uiStartup	1677	1253	2255	274	1946	2181
			load	710	603	1223	115	715	956
			domContentLoaded	702	595	1200	114	706	946
			domInteractive	42	19	272	44	33	144
			firstPaint	297	93	1209	212	339	713
			backgroundConnect	85	7	607	172	23	568
			firstReactRender	62	47	163	15	66	84
			getState	192	147	782	80	192	233
			initialActions	1	0	3	1	1	2
			loadScripts	699	593	1190	113	703	943
			setupStore	21	7	69	14	19	51
			numNetworkReqs	78	62	159	23	74	146
Firefox	Browserify	Standard Home	uiStartup	1301	1073	1894	162	1367	1665
			load	1073	924	1524	102	1127	1236
			domContentLoaded	1072	924	1523	102	1127	1236
			domInteractive	57	30	146	28	83	108
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	18	205	33	45	119
			firstReactRender	23	18	57	7	24	34
			getState	16	5	161	26	10	82
			initialActions	1	0	3	1	1	2
			loadScripts	1044	905	1503	95	1096	1195
			setupStore	14	5	171	21	11	46
			numNetworkReqs	12	5	67	17	6	64
	Browserify	Power User Home	uiStartup	2860	1923	4537	726	3636	4197
			load	1320	988	2549	418	1283	2301
			domContentLoaded	1319	983	2549	418	1283	2301
			domInteractive	97	35	348	59	109	247
			firstPaint	-	-	-	-	-	-
			backgroundConnect	173	24	1048	236	153	917
			firstReactRender	58	36	123	18	60	104
			getState	264	69	1017	245	332	853
			initialActions	3	0	49	6	2	3
			loadScripts	1230	963	2377	340	1246	2161
			setupStore	150	9	1101	227	141	688
			numNetworkReqs	84	50	223	35	101	168
	Webpack	Standard Home	uiStartup	1501	1291	1974	141	1586	1822
			load	1247	1082	1514	100	1312	1458
			domContentLoaded	1246	1081	1513	100	1312	1458
			domInteractive	62	27	149	32	86	128
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	20	162	27	47	100
			firstReactRender	30	20	164	18	30	72
			getState	13	7	104	11	14	27
			initialActions	1	0	2	1	2	2
			loadScripts	1217	1059	1450	92	1290	1393
			setupStore	16	6	158	22	11	42
			numNetworkReqs	12	5	67	17	7	63
	Webpack	Power User Home	uiStartup	3263	2037	6560	992	4206	4901
			load	1704	1128	4932	645	2235	2766
			domContentLoaded	1703	1127	4932	645	2234	2765
			domInteractive	174	28	3357	392	110	994
			firstPaint	-	-	-	-	-	-
			backgroundConnect	237	24	1597	346	193	1170
			firstReactRender	66	39	235	33	65	149
			getState	275	87	1242	239	270	847
			initialActions	2	0	7	1	2	6
			loadScripts	1577	1114	4917	584	1655	2669
			setupStore	131	5	1089	202	129	685
			numNetworkReqs	78	60	131	22	73	128

📊 Page Load Benchmark Results

Current Commit: bff89c8 | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 729ms (±61ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 90ms (±127ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.01s	1.37s	1.06s	1.37s
domContentLoaded	729ms	61ms	697ms	1.29s	744ms	1.29s
firstPaint	90ms	127ms	60ms	1.35s	88ms	1.35s
firstContentfulPaint	90ms	127ms	60ms	1.35s	88ms	1.35s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 124 Bytes (0%)
ui: 2.46 KiB (0.03%)
common: 309 Bytes (0%)

INFRA-3180:Fix create pr workflow commit.csv issue

4b935f4

metamaskbot added the team-dev-ops DevOps team label Dec 3, 2025

github-actions Bot added the size-XS label Dec 3, 2025

gauthierpetetin reviewed Dec 3, 2025

View reviewed changes

INFRA-3180: Update create pr workflow to use new github-tools version

85a4e2d

gauthierpetetin previously approved these changes Dec 3, 2025

View reviewed changes

gauthierpetetin self-requested a review December 3, 2025 15:53

gauthierpetetin reviewed Dec 3, 2025

View reviewed changes

INFRA-3180-Update to use new github-tools version

bff89c8

XxdpavelxX dismissed gauthierpetetin’s stale review via bff89c8 December 3, 2025 18:15

gauthierpetetin approved these changes Dec 3, 2025

View reviewed changes

XxdpavelxX self-assigned this Dec 3, 2025

XxdpavelxX requested a review from gauthierpetetin December 3, 2025 18:17

gauthierpetetin approved these changes Dec 3, 2025

View reviewed changes

jake-perkins approved these changes Dec 3, 2025

View reviewed changes

XxdpavelxX enabled auto-merge December 3, 2025 18:27

bsgrigorov approved these changes Dec 3, 2025

View reviewed changes

XxdpavelxX added this pull request to the merge queue Dec 3, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 3, 2025

XxdpavelxX added this pull request to the merge queue Dec 3, 2025

Merged via the queue into main with commit 74e5896 Dec 3, 2025
647 of 653 checks passed

XxdpavelxX deleted the INFRA-3180-CreatePRTeamJsonFix branch December 3, 2025 21:02

github-actions Bot locked and limited conversation to collaborators Dec 3, 2025

metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: INFRA-3180:Fix create pr workflow commit.csv issue#38526

chore: INFRA-3180:Fix create pr workflow commit.csv issue#38526
XxdpavelxX merged 3 commits into
mainfrom
INFRA-3180-CreatePRTeamJsonFix

XxdpavelxX commented Dec 3, 2025 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Dec 3, 2025

Uh oh!

gauthierpetetin Dec 3, 2025

Uh oh!

XxdpavelxX Dec 3, 2025

Uh oh!

gauthierpetetin Dec 3, 2025

Uh oh!

metamaskbot commented Dec 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

XxdpavelxX commented Dec 3, 2025 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Dec 3, 2025

Uh oh!

gauthierpetetin Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

XxdpavelxX Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

gauthierpetetin Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Dec 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

XxdpavelxX commented Dec 3, 2025 •

edited by cursor Bot

Loading