Skip to content

release(runway): cherry-pick fix(release branch name): cleanup deprecated release branch name cp-13.6.0#37015

Merged
gauthierpetetin merged 1 commit into
release/13.6.0from
runway-cherry-pick-13.6.0-1761044180
Oct 21, 2025
Merged

release(runway): cherry-pick fix(release branch name): cleanup deprecated release branch name cp-13.6.0#37015
gauthierpetetin merged 1 commit into
release/13.6.0from
runway-cherry-pick-13.6.0-1761044180

Conversation

@runway-github

@runway-github runway-github Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Description

Since we've aligned Extension and Mobile release branch names, we no
longer use the deprecated format: Version-vx.y.z.
The purpose of this PR is to cleanup the repo and remove all traces of
the deprecated format for release branch names.

Similar changes from github-tools repo can be found in this PR and have
been imported: MetaMask/github-tools#146

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Drop all support for Version-vX.Y.Z branches; only release/X.Y.Z is recognized across scripts, workflows, and build logic, plus update some GitHub Tools refs.

  • CI/Workflows:
    • Narrow triggers/conditions to release/* only in auto-create-release-pr.yml, check-attributions.yml, check-pr-max-lines.yml, close-bug-report.yml, create-bug-report.yml, main.yml, publish-prerelease.yml, release-pr-approval.yml, repository-health-checks.yml (changelog checks), and auto-update-pr-targeting-release.yml.
    • tag-release-branch.yml: accept and validate only release/X.Y.Z branches.
    • Update GitHub Tools refs in create-release-pr-legacy.yml and get-release-timelines.yml to commit 3b4244a....
  • Scripts:
    • .github/scripts/extract-semver.sh: remove Version-v handling; require release/X.Y.Z.
    • .github/scripts/get-next-semver-version.sh: compute highest version from release/* only.
    • .github/scripts/close-release-bug-report-issue.ts: extract version only from release/X.Y.Z.
  • Build:
    • development/build/utils.js: classify ENVIRONMENT.RELEASE_CANDIDATE only for release/X.Y.Z branches.

Written by Cursor Bugbot for commit 09bf651. This will update automatically on new commits. Configure here.

b2534a9

…ated release branch name cp-13.6.0 (#36991)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Since we've aligned Extension and Mobile release branch names, we no
longer use the deprecated format: `Version-vx.y.z`.
The purpose of this PR is to cleanup the repo and remove all traces of
the deprecated format for release branch names.

Similar changes from github-tools repo can be found in this PR and have
been imported: MetaMask/github-tools#146

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36991?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Standardizes on `release/X.Y.Z` by removing `Version-vX.Y.Z` support
across workflows, scripts, and build utils.
> 
> - **CI/Workflows**:
> - Restrict triggers and conditions to `release/*` (remove
`Version-v*`) in `auto-create-release-pr.yml`,
`auto-update-pr-targeting-release.yml`, `check-attributions.yml`,
`check-pr-max-lines.yml`, `close-bug-report.yml`,
`create-bug-report.yml`, `main.yml`, `publish-prerelease.yml`,
`release-pr-approval.yml`, `repository-health-checks.yml`,
`tag-release-branch.yml`.
> - **Scripts**:
> - `scripts/extract-semver.sh`: accept only `release/X.Y.Z`; update
error message.
> - `scripts/get-next-semver-version.sh`: derive next version from
`release/*` branches only.
> - `scripts/close-release-bug-report-issue.ts`: extract version only
from `release/X.Y.Z`.
> - **Build**:
> - `development/build/utils.js`: detect release-candidate env only for
`release/X.Y.Z` branches.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
33a5309. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Oct 21, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

📊 Page Load Benchmark Results

Current Commit: 09bf651 | Date: 10/21/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.01s (±73ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 700ms (±68ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.01s 73ms 962ms 1.30s 1.24s 1.30s
domContentLoaded 700ms 68ms 663ms 957ms 911ms 957ms
firstPaint 76ms 11ms 64ms 172ms 84ms 172ms
firstContentfulPaint 76ms 11ms 64ms 172ms 84ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [09bf651]
UI Startup Metrics (1205 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1205108713905412411291
load103991311724810711113
domContentLoaded103390711674810641109
domInteractive17135771637
firstPaint69378117241910661106
backgroundConnect2482352766251258
firstReactRender25176972638
getState15589101733
initialActions50486514
loadScripts79067591347823866
setupStore962431014
WebpackHomeuiStartup78267299863806897
load59053284869594754
domContentLoaded58252783969589748
domInteractive15115881434
firstPaint17350805180158656
backgroundConnect22114372734
firstReactRender24165783034
getState831531013
initialActions2013236
loadScripts58052583168587746
setupStore104123121113
FirefoxBrowserifyHomeuiStartup1397118516659414531553
load1202103014148012551359
domContentLoaded1202103014148012551359
domInteractive1093235757109272
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30186383541
firstReactRender24214532434
getState84486817
initialActions41828311
loadScripts1182101413917912341335
setupStore11568101030
WebpackHomeuiStartup15701345190410116121767
load1348118515597714041497
domContentLoaded1347118515597714041497
domInteractive1073139558111201
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect342074104052
firstReactRender312281133371
getState94949814
initialActions41294310
loadScripts1325116915327713841477
setupStore146168211160

@gauthierpetetin gauthierpetetin merged commit 86c9186 into release/13.6.0 Oct 21, 2025
321 of 324 checks passed
@gauthierpetetin gauthierpetetin deleted the runway-cherry-pick-13.6.0-1761044180 branch October 21, 2025 12:47
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 21, 2025
@metamaskbot metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 21, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-13.6.0 on PR, as PR was cherry-picked in branch 13.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.6.0 Issue or pull request that will be included in release 13.6.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants