release: fix "Create Release Pull Request"#33792
Merged
Merged
Conversation
metamaskbot
added
team-extension-platform
HowardBraham
force-pushed
the
chore/12.22.0-Changelog
branch
from
5948fed to
9b41c18
Compare
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
changed the title
Collaborator
Builds ready [9b41c18]
UI Startup Metrics (1226 ± 66 ms)
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 245 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 2571 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1973 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 213 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1996 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 278 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Sum of mean exceeds: 21ms | Sum of p95 exceeds: 367ms Sum of all benchmark exceeds: 388ms Bundle size diffs
|
HowardBraham
added
the
no-changelog
HowardBraham
force-pushed
the
chore/12.22.0-Changelog
branch
from
9b41c18 to
0833bcc
Compare
Collaborator
Builds ready [0833bcc]
UI Startup Metrics (1211 ± 55 ms)
Benchmark value 2643 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 1986 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 115 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 269 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1971 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive Sum of mean exceeds: 10ms | Sum of p95 exceeds: 467ms Sum of all benchmark exceeds: 477ms Bundle size diffs
|
jvbriones
reviewed
Jun 20, 2025
| base-branch: ${{ inputs.base-branch }} | ||
| semver-version: ${{ inputs.semver-version }} | ||
| previous-version-tag: ${{ inputs.previous-version-tag }} | ||
| previous-version-tag: Version-v${{ inputs.previous-semver-version }} |
Contributor
There was a problem hiding this comment.
I think we need to review this, since this param is an input for generate-rc-commits.mjs.
Maybe the fix just needs to be done in that script in a separate PR.
jvbriones
approved these changes
Jun 20, 2025
itsyoboieltr
approved these changes
Jun 23, 2025
metamaskbot
added
the
release-12.23.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create Release Pull Requestcreate-release-pr.ymlfix: "Create Release Pull Request" on Extension github-tools#79