Add additional validation to EIP7702 methods #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
reviewed
Mar 18, 2025
| ); | ||
| } | ||
|
|
||
| if (!isValidHexAddress(contractAddress as Hex)) { |
Contributor
There was a problem hiding this comment.
For the record: This function does verify the address length too.
See: https://github.com/MetaMask/utils/blob/v11.3.0/src/hex.ts#L15-L18 ({40} in hex-format, each bytes is 2-digits/chars long, which makes it a length of 20 bytes).
ccharly
previously approved these changes
Mar 18, 2025
Contributor
ccharly
left a comment
ccharly
left a comment
There was a problem hiding this comment.
Code LGTM! I've left 2 small comments for the tests, but the actual logic is good, so up to you if you want to change this or not. 😄 thanks!
Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com>
ccharly
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation of the Authorization object, as per EIP-7702 specification https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md
Also renames some tests to align with renamed function names.